diff mbox

[U-Boot,08/17] km/powerpc82xx: remove unused function

Message ID 1447426768-23226-9-git-send-email-valentin.longchamp@keymile.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Valentin Longchamp Nov. 13, 2015, 2:59 p.m. UTC 
From: Holger Brunck <holger.brunck@keymile.com>

commit 0a4f88b98 removed the usage of our setports function, but the
function itself were not removed. So toss it it's dead code.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
---

 board/keymile/km82xx/km82xx.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Heiko Schocher Nov. 16, 2015, 11:01 a.m. UTC | #1 
Hello Valentin,

Am 13.11.2015 um 15:59 schrieb Valentin Longchamp:
> From: Holger Brunck <holger.brunck@keymile.com>
>
> commit 0a4f88b98 removed the usage of our setports function, but the
> function itself were not removed. So toss it it's dead code.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
>
>   board/keymile/km82xx/km82xx.c | 16 ----------------
>   1 file changed, 16 deletions(-)


Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/board/keymile/km82xx/km82xx.c b/board/keymile/km82xx/km82xx.c
> index 70f816b..01a3c20 100644
> --- a/board/keymile/km82xx/km82xx.c
> +++ b/board/keymile/km82xx/km82xx.c
> @@ -447,22 +447,6 @@ int get_scl(void)
>   	return get_pin(SCL_MASK, 3);
>   }
>
> -#if defined(CONFIG_HARD_I2C)
> -static void setports(int gpio)
> -{
> -	ioport_t *iop = ioport_addr((immap_t *)CONFIG_SYS_IMMR, 3);
> -
> -	if (gpio) {
> -		clrbits_be32(&iop->ppar, (SDA_MASK | SCL_MASK));
> -		clrbits_be32(&iop->podr, (SDA_MASK | SCL_MASK));
> -	} else {
> -		setbits_be32(&iop->ppar, (SDA_MASK | SCL_MASK));
> -		clrbits_be32(&iop->pdir, (SDA_MASK | SCL_MASK));
> -		setbits_be32(&iop->podr, (SDA_MASK | SCL_MASK));
> -	}
> -}
> -#endif
> -
>   void ft_board_setup(void *blob, bd_t *bd)
>   {
>   	ft_cpu_setup(blob, bd);
>
diff mbox

Patch

diff --git a/board/keymile/km82xx/km82xx.c b/board/keymile/km82xx/km82xx.c
index 70f816b..01a3c20 100644
--- a/board/keymile/km82xx/km82xx.c
+++ b/board/keymile/km82xx/km82xx.c
@@ -447,22 +447,6 @@  int get_scl(void)
 	return get_pin(SCL_MASK, 3);
 }
 
-#if defined(CONFIG_HARD_I2C)
-static void setports(int gpio)
-{
-	ioport_t *iop = ioport_addr((immap_t *)CONFIG_SYS_IMMR, 3);
-
-	if (gpio) {
-		clrbits_be32(&iop->ppar, (SDA_MASK | SCL_MASK));
-		clrbits_be32(&iop->podr, (SDA_MASK | SCL_MASK));
-	} else {
-		setbits_be32(&iop->ppar, (SDA_MASK | SCL_MASK));
-		clrbits_be32(&iop->pdir, (SDA_MASK | SCL_MASK));
-		setbits_be32(&iop->podr, (SDA_MASK | SCL_MASK));
-	}
-}
-#endif
-
 void ft_board_setup(void *blob, bd_t *bd)
 {
 	ft_cpu_setup(blob, bd);