From patchwork Wed Jun  2 20:36:42 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Bug,584143] Re: qemu fails to set hdd serial number
Date: Wed, 02 Jun 2010 10:36:42 -0000
From: Luiz Capitulino <lcapitulino@redhat.com>
X-Patchwork-Id: 54432
Message-Id: <20100602203642.10895.89058.malone@potassium.ubuntu.com>
To: qemu-devel@nongnu.org

Bug exists in both current master and stable v0.12.4, but the suggested
fix doesn't leave room for the null terminating byte, will submit
upstream a better version.

** Changed in: qemu
       Status: New => In Progress


--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;