Patchwork [Bug,584143] Re: qemu fails to set hdd serial number

login
register
mail settings
Submitter Luiz Capitulino
Date June 2, 2010, 8:36 p.m.
Message ID <20100602203642.10895.89058.malone@potassium.ubuntu.com>
Download mbox | patch
Permalink /patch/54432/
State New
Headers show

Comments

Luiz Capitulino - June 2, 2010, 8:36 p.m.
Bug exists in both current master and stable v0.12.4, but the suggested
fix doesn't leave room for the null terminating byte, will submit
upstream a better version.

** Changed in: qemu
       Status: New => In Progress

Patch

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@ 
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;