diff mbox

[for-2.5] block: Call external_snapshot_clean after blockdev-snapshot

Message ID 1447419624-21918-1-git-send-email-berto@igalia.com
State New
Headers show

Commit Message

Alberto Garcia Nov. 13, 2015, 1 p.m. UTC 
Otherwise the AioContext will never be released.

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Fam Zheng Nov. 16, 2015, 6:09 a.m. UTC | #1 
On Fri, 11/13 15:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  blockdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
>          .prepare  = external_snapshot_prepare,
>          .commit   = external_snapshot_commit,
>          .abort = external_snapshot_abort,
> +        .clean = external_snapshot_clean,
>      },
>      [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
>          .instance_size = sizeof(ExternalSnapshotState),
> -- 
> 2.6.2
> 

Reviewed-by: Fam Zheng <famz@redhat.com>
Max Reitz Nov. 16, 2015, 8:23 p.m. UTC | #2 
On 13.11.2015 14:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  blockdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
>          .prepare  = external_snapshot_prepare,
>          .commit   = external_snapshot_commit,
>          .abort = external_snapshot_abort,
> +        .clean = external_snapshot_clean,
>      },
>      [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
>          .instance_size = sizeof(ExternalSnapshotState),

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block


Max
diff mbox

Patch

diff --git a/blockdev.c b/blockdev.c
index fc85128..4dcc510 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2070,6 +2070,7 @@  static const BlkActionOps actions[] = {
         .prepare  = external_snapshot_prepare,
         .commit   = external_snapshot_commit,
         .abort = external_snapshot_abort,
+        .clean = external_snapshot_clean,
     },
     [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
         .instance_size = sizeof(ExternalSnapshotState),