diff mbox

[U-Boot] Juno: don't print PCI debug information by default

Message ID 1447413946-31058-1-git-send-email-andre.przywara@arm.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Andre Przywara Nov. 13, 2015, 11:25 a.m. UTC
On a Juno r1 the PCI controller init routine outputs the rather boring
ATR entry information.
Do this only with DEBUG defined to avoid cluttering the user's
terminal.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 board/armltd/vexpress64/pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ryan Harkin Nov. 13, 2015, 3:04 p.m. UTC | #1
On 13 November 2015 at 11:25, Andre Przywara <andre.przywara@arm.com> wrote:
> On a Juno r1 the PCI controller init routine outputs the rather boring
> ATR entry information.
> Do this only with DEBUG defined to avoid cluttering the user's
> terminal.

Good idea.

>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Ryan Harkin <ryan.harkin@linaro.org>


> ---
>  board/armltd/vexpress64/pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/armltd/vexpress64/pcie.c b/board/armltd/vexpress64/pcie.c
> index 7b999e8..eb23dd5 100644
> --- a/board/armltd/vexpress64/pcie.c
> +++ b/board/armltd/vexpress64/pcie.c
> @@ -87,7 +87,7 @@ void xr3pci_set_atr_entry(unsigned long base, unsigned long src_addr,
>         writel((u32)(trsl_addr >> 32), base + XR3PCI_ATR_TRSL_ADDR_HIGH);
>         writel(trsl_param, base + XR3PCI_ATR_TRSL_PARAM);
>
> -       printf("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param: 0x%06x)\n",
> +       debug("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param: 0x%06x)\n",
>                src_addr, (trsl_param & 0x400000) ? "<-" : "->", trsl_addr,
>                ((u64)1) << window_size, trsl_param);
>  }
> --
> 2.5.1
>
Tom Rini Nov. 22, 2015, 3:55 p.m. UTC | #2
On Fri, Nov 13, 2015 at 11:25:46AM +0000, Andre Przywara wrote:

> On a Juno r1 the PCI controller init routine outputs the rather boring
> ATR entry information.
> Do this only with DEBUG defined to avoid cluttering the user's
> terminal.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Ryan Harkin <ryan.harkin@linaro.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/armltd/vexpress64/pcie.c b/board/armltd/vexpress64/pcie.c
index 7b999e8..eb23dd5 100644
--- a/board/armltd/vexpress64/pcie.c
+++ b/board/armltd/vexpress64/pcie.c
@@ -87,7 +87,7 @@  void xr3pci_set_atr_entry(unsigned long base, unsigned long src_addr,
 	writel((u32)(trsl_addr >> 32), base + XR3PCI_ATR_TRSL_ADDR_HIGH);
 	writel(trsl_param, base + XR3PCI_ATR_TRSL_PARAM);
 
-	printf("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param: 0x%06x)\n",
+	debug("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param: 0x%06x)\n",
 	       src_addr, (trsl_param & 0x400000) ? "<-" : "->", trsl_addr,
 	       ((u64)1) << window_size, trsl_param);
 }