From patchwork Wed Jun 2 13:53:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: thomas.koeller@baslerweb.com X-Patchwork-Id: 54373 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wy0-f184.google.com (mail-wy0-f184.google.com [74.125.82.184]) by ozlabs.org (Postfix) with ESMTP id 1244EB7D2E for ; Wed, 2 Jun 2010 23:53:47 +1000 (EST) Received: by wya21 with SMTP id 21sf2267509wya.11 for ; Wed, 02 Jun 2010 06:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:mime-version:x-beenthere:received :received:received:received:received-spf:received:received:from:to :cc:subject:date:message-id:x-mailer:in-reply-to:references :x-originalarrivaltime:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=nMgC0iQ3uFGa0jB4HR4GfhLiVRysqs1hFTfFETfDd2I=; b=r8hq2RJbrx55aSUZFd/OO5sewS9gNCBfVAE47fY5Jp+IF5j/g2Mu78cj3tFwE8+OKY T6s36q6OroS3NXHtiijN6vMdCsL2pw9r1bR/+VUP+5ogaCD1FZcVNYJ7jByt5fQj+k/T yeuOhZoAgrAD+o1091KHPFn++m7tEPDGVsJcE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:x-originalarrivaltime :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; b=dSUsdwCLJkaAsNXIPSMIXiEzsBlEWBGjHJ6ZGXMkbzNTvHWE4lt9BoFjnH1wsXej6L uK3C4HtmI5+OwtoE+GV8AhiTnmo0Fvdys0PwNG+eq5Ir7AZBj61OPniNN1IuX1UbgEj8 htAvkAXPlp3k0ribgP4ehHR4D0t/o+ha+/ZlE= Received: by 10.223.4.212 with SMTP id 20mr338653fas.15.1275486825140; Wed, 02 Jun 2010 06:53:45 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.204.6.8 with SMTP id 8ls644639bkx.3.p; Wed, 02 Jun 2010 06:53:44 -0700 (PDT) Received: by 10.204.8.151 with SMTP id h23mr157197bkh.8.1275486824471; Wed, 02 Jun 2010 06:53:44 -0700 (PDT) Received: by 10.204.8.151 with SMTP id h23mr157196bkh.8.1275486824438; Wed, 02 Jun 2010 06:53:44 -0700 (PDT) Received: from mail01.baslerweb.com (mail01.baslerweb.com [80.156.24.166]) by gmr-mx.google.com with ESMTP id q19si1277194bks.1.2010.06.02.06.53.44; Wed, 02 Jun 2010 06:53:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of Thomas.Koeller@baslerweb.com designates 80.156.24.166 as permitted sender) client-ip=80.156.24.166; Received: from unknown (HELO AHR075S.basler.corp) ([172.16.20.75]) by mail01-out.baslerweb.com with ESMTP; 02 Jun 2010 15:53:22 +0200 Received: from rd-ipcam.basler.corp ([172.16.13.131]) by AHR075S.basler.corp with Microsoft SMTPSVC(6.0.3790.4675); Wed, 2 Jun 2010 15:53:44 +0200 From: thomas.koeller@baslerweb.com To: p_gortmaker@yahoo.com, rtc-linux@googlegroups.com Cc: Thomas Koeller Subject: [rtc-linux] [PATCH 1/4] rtc: rtc-rs5c372: fixed write buffer size Date: Wed, 2 Jun 2010 15:53:04 +0200 Message-Id: <1275486787-30406-2-git-send-email-thomas.koeller@baslerweb.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1275486787-30406-1-git-send-email-thomas.koeller@baslerweb.com> References: <1275486787-30406-1-git-send-email-thomas.koeller@baslerweb.com> X-OriginalArrivalTime: 02 Jun 2010 13:53:44.0017 (UTC) FILETIME=[03DB3C10:01CB025B] X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of Thomas.Koeller@baslerweb.com designates 80.156.24.166 as permitted sender) smtp.mail=Thomas.Koeller@baslerweb.com X-Original-Sender: thomas.koeller@baslerweb.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , From: Thomas Koeller When setting a new time value, the oscillator adjustment register was overwritten with the contents of an uninitialized memory byte. Signed-off-by: Thomas Koeller Acked-by: Wan ZongShun --- drivers/rtc/rtc-rs5c372.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 2f2c68d..211cacd 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -206,7 +206,7 @@ static int rs5c372_get_datetime(struct i2c_client *client, struct rtc_time *tm) static int rs5c372_set_datetime(struct i2c_client *client, struct rtc_time *tm) { struct rs5c372 *rs5c = i2c_get_clientdata(client); - unsigned char buf[8]; + unsigned char buf[7]; int addr; dev_dbg(&client->dev, "%s: tm is secs=%d, mins=%d, hours=%d "