From patchwork Wed Jun 2 13:01:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Levitsky X-Patchwork-Id: 54368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C6155B7D2D for ; Wed, 2 Jun 2010 23:04:35 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OJnaC-0000fV-La; Wed, 02 Jun 2010 13:02:08 +0000 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OJnaB-0000df-0j for linux-mtd@lists.infradead.org; Wed, 02 Jun 2010 13:02:07 +0000 Received: by mail-fx0-f49.google.com with SMTP id 15so4682798fxm.36 for ; Wed, 02 Jun 2010 06:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=6GelJ++UjbhrajMV4E9W58uJxhtoaR7VLdvP5QzQrDQ=; b=T7337wbkWmXUMH5VevOupkqVi15E9TRjxDuEebb7IMXEDMEYJxGNlquueBPL4LvXo8 rmIRpWOGcUQJSEeSM6H//S0oq5lqmFWHyOhyEdcwBV+VylfpDyEFvPvr92JkS2ARrWeZ hKD2zYYey++fiFRMh5YcJ0y1LC1fe1XMKKvuM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=pdSiFg7yGtvrdO1SodsPP8Jy7bwSCrofNmTkuWcdAU7i0LdXGDL3EKcoFTCybilSnV C8vdD+mFw36ExybMYNKYzpwDVNhNVEdiekYgAgLUWTOyqFHdFHKIUU9vQrjOwS7Ljsik wIlxCAjbN3M+iTkroKzktcl7KMdOEkD+Gr2ck= Received: by 10.223.58.83 with SMTP id f19mr8621366fah.88.1275483725391; Wed, 02 Jun 2010 06:02:05 -0700 (PDT) Received: from localhost.localdomain ([77.127.199.160]) by mx.google.com with ESMTPS id j23sm52210456faa.14.2010.06.02.06.02.03 (version=SSLv3 cipher=RC4-MD5); Wed, 02 Jun 2010 06:02:04 -0700 (PDT) From: Maxim Levitsky To: dwmw2 Subject: [PATCH 1/4] r852: register IRQ as last step Date: Wed, 2 Jun 2010 16:01:45 +0300 Message-Id: <1275483708-11929-2-git-send-email-maximlevitsky@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1275483708-11929-1-git-send-email-maximlevitsky@gmail.com> References: <1275483708-11929-1-git-send-email-maximlevitsky@gmail.com> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100602_090207_162034_35E09FB3 X-CRM114-Status: GOOD ( 11.35 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is freemail (maximlevitsky[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd , Maxim Levitsky X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Maxim Levitsky Otherwise, if it fires right away, it might access uninitialized spinlock Signed-off-by: Maxim Levitsky --- drivers/mtd/nand/r852.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c index 78a4232..20a654a 100644 --- a/drivers/mtd/nand/r852.c +++ b/drivers/mtd/nand/r852.c @@ -940,18 +940,19 @@ int r852_probe(struct pci_dev *pci_dev, const struct pci_device_id *id) r852_dma_test(dev); + dev->irq = pci_dev->irq; + spin_lock_init(&dev->irqlock); + + dev->card_detected = 0; + r852_card_update_present(dev); + /*register irq handler*/ error = -ENODEV; if (request_irq(pci_dev->irq, &r852_irq, IRQF_SHARED, DRV_NAME, dev)) goto error10; - dev->irq = pci_dev->irq; - spin_lock_init(&dev->irqlock); - /* kick initial present test */ - dev->card_detected = 0; - r852_card_update_present(dev); queue_delayed_work(dev->card_workqueue, &dev->card_detect_work, 0);