From patchwork Wed Nov 11 20:27:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 543089 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AC35E1402D4 for ; Thu, 12 Nov 2015 07:28:17 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=gtXLZe0k; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbbKKU1q (ORCPT ); Wed, 11 Nov 2015 15:27:46 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:32925 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306AbbKKU1n (ORCPT ); Wed, 11 Nov 2015 15:27:43 -0500 Received: by wmec201 with SMTP id c201so2502459wme.0; Wed, 11 Nov 2015 12:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l80OJJXpTe47uBINzBIElPz37Ug3H0pDZ7Q8XakxNUs=; b=gtXLZe0kIexJO9yiQ/V2ELbT2Ww60lcLxQVRU1zEvFImjzNQoErcNIhWRjKQzL89AV mYhzUSP+ot2eA3mYT9FvP5OfMmxqmZEDmuYPeh0tu2VV1DEiShpXvS9VY0++S7Ga+PgQ MzXTCmRcT/ZKxOeaDltZhwYTgS9ccnf7Hag90SHOUBoduX5/Nl9InpMyKEbGRdrrerE/ 3lI5t4f4RUVE+I4iD/MXfDAFBGzrYHswUkPQiN4xh6Ko54bPcdKZAkGhloS3jhBlbkta GEiS9aRTFNQr/UwdGtFcdv1TQ5JuYtMYLwB69axFw4080EM2VbzNc/qw4OMUjmJlJsQU VVzw== X-Received: by 10.28.88.135 with SMTP id m129mr13900720wmb.67.1447273662582; Wed, 11 Nov 2015 12:27:42 -0800 (PST) Received: from Red.local (ANice-651-1-284-125.w83-201.abo.wanadoo.fr. [83.201.64.125]) by smtp.googlemail.com with ESMTPSA id l1sm11302398wmg.21.2015.11.11.12.27.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Nov 2015 12:27:42 -0800 (PST) From: LABBE Corentin To: gnurou@gmail.com, linus.walleij@linaro.org Cc: LABBE Corentin , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] gpio: syscon: fix a possible NULL dereference Date: Wed, 11 Nov 2015 21:27:35 +0100 Message-Id: <1447273657-1668-2-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> References: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org of_match_device could return NULL, and so cause a NULL pointer dereference later at line 199: priv->flags = of_id->data; Reported-by: coverity (CID 1324140) Signed-off-by: LABBE Corentin --- drivers/gpio/gpio-syscon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 045a952..7b25fdf 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -187,11 +187,15 @@ MODULE_DEVICE_TABLE(of, syscon_gpio_ids); static int syscon_gpio_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - const struct of_device_id *of_id = of_match_device(syscon_gpio_ids, dev); + const struct of_device_id *of_id; struct syscon_gpio_priv *priv; struct device_node *np = dev->of_node; int ret; + of_id = of_match_device(syscon_gpio_ids, dev); + if (!of_id) + return -ENODEV; + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM;