Patchwork Call trace related to bonding seen in 2.6.34

login
register
mail settings
Submitter Narendra K
Date June 1, 2010, 5:45 p.m.
Message ID <EDA0A4495861324DA2618B4C45DCB3EE612882@blrx3m08.blr.amer.dell.com>
Download mbox | patch
Permalink /patch/54269/
State RFC
Delegated to: David Miller
Headers show

Comments

Narendra K - June 1, 2010, 5:45 p.m.
Hello,

Call trace related to bond_mii_monitor  as described in this thread -
http://patchwork.ozlabs.org/patch/41288/ was seen on 2.6.34 kernel.
(Trace is similar to what is described in the post dated 2009-12-17
21:31:36.) The trace is seen when the network service is stopped. The
issue occurs when the network service is started and stopped in quick
succession. 

Bonding device configuration parameters are as below -

Bonding driver version:3.6.0
Mode: balance-alb (issue is also seen with active-backup mode)
Miimon=100
3 slaves with link up and one slave with link down.

Though this requires more thought and investigation, I thought this
could be a good data point. The below change to the bonding driver
seemed to make the issue go away -

drivers/net/bonding/bond_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

 out:




Any thoughts ?


With regards,
Narendra K


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/bonding/bond_main.c
b/drivers/net/bonding/bond_main.c
index 0075514..f280aaf 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2408,7 +2408,7 @@  void bond_mii_monitor(struct work_struct *work)
        }

 re_arm:
-       if (bond->params.miimon)
+       if (bond->params.miimon && !bond->kill_timers)
                queue_delayed_work(bond->wq, &bond->mii_work,
 
msecs_to_jiffies(bond->params.miimon));