| Message ID | alpine.OSX.2.00.1006011738330.299@localhost |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Finn Thain <fthain@telegraphics.com.au> Date: Tue, 1 Jun 2010 22:18:32 +1000 (EST) > > Use the request_irq() error code as the return value for mac8390_open(). > EAGAIN doesn't make sense for Nubus slot IRQs. Only this driver can claim > this IRQ (until the NIC is removed, which means everything is powered > down). > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux-2.6.34/drivers/net/mac8390.c =================================================================== --- linux-2.6.34.orig/drivers/net/mac8390.c 2010-06-01 20:20:29.000000000 +1000 +++ linux-2.6.34/drivers/net/mac8390.c 2010-06-01 20:22:23.000000000 +1000 @@ -643,12 +643,13 @@ static int __init mac8390_initdev(struct static int mac8390_open(struct net_device *dev) { + int err; + __ei_open(dev); - if (request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev)) { - pr_info("%s: unable to get IRQ %d.\n", dev->name, dev->irq); - return -EAGAIN; - } - return 0; + err = request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev); + if (err) + pr_info("%s: unable to get IRQ %d\n", dev->name, dev->irq); + return err; } static int mac8390_close(struct net_device *dev)
Use the request_irq() error code as the return value for mac8390_open(). EAGAIN doesn't make sense for Nubus slot IRQs. Only this driver can claim this IRQ (until the NIC is removed, which means everything is powered down). Signed-off-by: Finn Thain <fthain@telegraphics.com.au> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html