diff mbox

power: bq27xxx_battery: Add I2C module check dependency in Kconfig

Message ID 1447104183-13556-1-git-send-email-afd@ti.com
State Not Applicable
Headers show

Commit Message

Andrew Davis Nov. 9, 2015, 9:23 p.m. UTC
Check if I2C core has been built as a module when BATTERY_BQ27XXX
is built-in. If so disable I2C functionality.

Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 drivers/power/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann Nov. 9, 2015, 9:32 p.m. UTC | #1
On Monday 09 November 2015 15:23:03 Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
> 
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Thanks for the fix!

Acked-by: Arnd Bergmann <arnd@arndb.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel Nov. 10, 2015, 3:50 a.m. UTC | #2
Hi,

On Mon, Nov 09, 2015 at 03:23:03PM -0600, Andrew F. Davis wrote:
> Check if I2C core has been built as a module when BATTERY_BQ27XXX
> is built-in. If so disable I2C functionality.
> 
> Fixes: 6bd03ce3c12a ("power: bq27xxx_battery: Remove unneeded dependency in Kconfig")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Thanks, queued.

-- Sebastian
diff mbox

Patch

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 237d7aa..2f944d7 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -166,6 +166,7 @@  config BATTERY_BQ27XXX_I2C
 	bool "BQ27xxx I2C support"
 	depends on BATTERY_BQ27XXX
 	depends on I2C
+	depends on !(I2C=m && BATTERY_BQ27XXX=y)
 	default y
 	help
 	  Say Y here to enable support for batteries with BQ27xxx (I2C) chips.