Patchwork [LUCID,1/1] UBUNTU: hid-gyration does not support GYR4101US remote

login
register
mail settings
Submitter Lee Jones
Date June 1, 2010, 10:40 a.m.
Message ID <4C04E3AD.7010400@canonical.com>
Download mbox | patch
Permalink /patch/54165/
State Awaiting Upstream
Delegated to: Stefan Bader
Headers show

Comments

Lee Jones - June 1, 2010, 10:40 a.m.
Hi all,

BugLink: http://bugs.launchpad.net/bugs/584330
   
    The GYR4101US Gyration Media Center Remote is not currently
supported by the
    hid-gyration driver. The device has USB ID 0c16:0008. Without
hid-gyration
    support, many of the buttons on the remote do not function.

The following changes since commit f0819aaf4948e34a44d9d685615ddee74271cd70:
  Chase Douglas (1):
        UBUNTU: enforce CONFIG_TMPFS_POSIX_ACL=y

are available in the git repository at:

  git://kernel.ubuntu.com/lag/ubuntu-lucid.git lp584330

Lee Jones (1):
      UBUNTU: hid-gyration does not support GYR4101US remote

 drivers/hid/hid-core.c     |    1 +
 drivers/hid/hid-gyration.c |    1 +
 drivers/hid/hid-ids.h      |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)



Kind regards,
Lee
Chase Douglas - June 1, 2010, 12:37 p.m.
On Tue, 2010-06-01 at 11:40 +0100, Lee Jones wrote:
> Hi all,
> 
> BugLink: http://bugs.launchpad.net/bugs/584330
>    
>     The GYR4101US Gyration Media Center Remote is not currently
> supported by the
>     hid-gyration driver. The device has USB ID 0c16:0008. Without
> hid-gyration
>     support, many of the buttons on the remote do not function.

This is a perfect example of a patch that should be sent upstream to
stable@kernel.org. Device ID additions have very low regression
potential (though I did manage to cause one with an ALPS ID
addition :) ). Please see Documentation/stable_kernel_rules.txt in the
kernel source for instructions on how to do this. Feel free to ask any
questions about the exact form of your submission, and Stefan would be a
great resource for verification as he has talked directly with gregkh
about the preferred submission format.

-- Chase
Stefan Bader - June 1, 2010, 1:17 p.m.
Hi Lee,

as Chase said, that looks like a stable candidate. First question, is that a
change you did, which is not upstream, yet?
If yes, you can check with './scripts/get_maintainer.pl <yourpatch>' which
people/lists this probably should go to. Put a line "CC: stable@kernel.org"
below your signed-off-by line. Check at least that it applies to .32 and upstream.
Then send the patch to lkml and to whatever else seems reasonable from
get_maintainer.
Probably I missed some things, feel free to ask.

-Stefan

On 06/01/2010 12:40 PM, Lee Jones wrote:
> Hi all,
> 
> BugLink: http://bugs.launchpad.net/bugs/584330
>    
>     The GYR4101US Gyration Media Center Remote is not currently
> supported by the
>     hid-gyration driver. The device has USB ID 0c16:0008. Without
> hid-gyration
>     support, many of the buttons on the remote do not function.
> 
> The following changes since commit f0819aaf4948e34a44d9d685615ddee74271cd70:
>   Chase Douglas (1):
>         UBUNTU: enforce CONFIG_TMPFS_POSIX_ACL=y
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/lag/ubuntu-lucid.git lp584330
> 
> Lee Jones (1):
>       UBUNTU: hid-gyration does not support GYR4101US remote
> 
>  drivers/hid/hid-core.c     |    1 +
>  drivers/hid/hid-gyration.c |    1 +
>  drivers/hid/hid-ids.h      |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 77b5952..eef2f7c 100644 (file)
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1307,6 +1307,7 @@ static const struct hid_device_id hid_blacklist[] = {
>         { HID_USB_DEVICE(USB_VENDOR_ID_GREENASIA, 0x0012) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE_2) },
> +       { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE_3) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON,
> USB_DEVICE_ID_KS_SLIMBLADE) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC,
> USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
> diff --git a/drivers/hid/hid-gyration.c b/drivers/hid/hid-gyration.c
> index cab13e8..9de37d0 100644 (file)
> --- a/drivers/hid/hid-gyration.c
> +++ b/drivers/hid/hid-gyration.c
> @@ -70,6 +70,7 @@ static int gyration_event(struct hid_device *hdev,
> struct hid_field *field,
>  static const struct hid_device_id gyration_devices[] = {
>         { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE_2) },
> +       { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
> USB_DEVICE_ID_GYRATION_REMOTE_3) },
>         { }
>  };
>  MODULE_DEVICE_TABLE(hid, gyration_devices);
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index e810591..5c32c72 100644 (file)
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -257,6 +257,7 @@
>  #define USB_VENDOR_ID_GYRATION         0x0c16
>  #define USB_DEVICE_ID_GYRATION_REMOTE  0x0002
>  #define USB_DEVICE_ID_GYRATION_REMOTE_2 0x0003
> +#define USB_DEVICE_ID_GYRATION_REMOTE_3 0x0008
>  
>  #define USB_VENDOR_ID_HAPP             0x078b
>  #define USB_DEVICE_ID_UGCI_DRIVING     0x0010
> 
> Kind regards,
> Lee
>
Lee Jones - June 1, 2010, 1:28 p.m.
Hi Stefan,

No, it's not my patch.

They guy who filed the bug also sent it to upstream.

I believe the intention was to update Lucid with it and for it to appear
in Maverick via upstream

Kind regards,
Lee

On 01/06/10 14:17, Stefan Bader wrote:
> Hi Lee,
>
> as Chase said, that looks like a stable candidate. First question, is that a
> change you did, which is not upstream, yet?
> If yes, you can check with './scripts/get_maintainer.pl <yourpatch>' which
> people/lists this probably should go to. Put a line "CC: stable@kernel.org"
> below your signed-off-by line. Check at least that it applies to .32 and upstream.
> Then send the patch to lkml and to whatever else seems reasonable from
> get_maintainer.
> Probably I missed some things, feel free to ask.
>
> -Stefan
>
Tim Gardner - June 1, 2010, 1:28 p.m.
On 06/01/2010 07:17 AM, Stefan Bader wrote:
> Hi Lee,
>
> as Chase said, that looks like a stable candidate. First question, is that a
> change you did, which is not upstream, yet?
> If yes, you can check with './scripts/get_maintainer.pl<yourpatch>' which
> people/lists this probably should go to. Put a line "CC: stable@kernel.org"
> below your signed-off-by line. Check at least that it applies to .32 and upstream.
> Then send the patch to lkml and to whatever else seems reasonable from
> get_maintainer.
> Probably I missed some things, feel free to ask.
>
> -Stefan
>

Its a straightforward upstream cherry-pick from 
c2fd1a4ebf9127c280d227acb635eb1df213439c

rtg

Patch

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 77b5952..eef2f7c 100644 (file)
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1307,6 +1307,7 @@  static const struct hid_device_id hid_blacklist[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_GREENASIA, 0x0012) },
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE) },
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE_2) },
+       { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE_3) },
        { HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON,
USB_DEVICE_ID_KS_SLIMBLADE) },
        { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
        { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC,
USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
diff --git a/drivers/hid/hid-gyration.c b/drivers/hid/hid-gyration.c
index cab13e8..9de37d0 100644 (file)
--- a/drivers/hid/hid-gyration.c
+++ b/drivers/hid/hid-gyration.c
@@ -70,6 +70,7 @@  static int gyration_event(struct hid_device *hdev,
struct hid_field *field,
 static const struct hid_device_id gyration_devices[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE) },
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE_2) },
+       { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION,
USB_DEVICE_ID_GYRATION_REMOTE_3) },
        { }
 };
 MODULE_DEVICE_TABLE(hid, gyration_devices);
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index e810591..5c32c72 100644 (file)
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -257,6 +257,7 @@ 
 #define USB_VENDOR_ID_GYRATION         0x0c16
 #define USB_DEVICE_ID_GYRATION_REMOTE  0x0002
 #define USB_DEVICE_ID_GYRATION_REMOTE_2 0x0003
+#define USB_DEVICE_ID_GYRATION_REMOTE_3 0x0008
 
 #define USB_VENDOR_ID_HAPP             0x078b
 #define USB_DEVICE_ID_UGCI_DRIVING     0x0010