| Message ID | 1447014141-3565-5-git-send-email-phil@nwl.cc |
|---|---|
| State | Superseded, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
Hello. On 11/08/2015 11:22 PM, Phil Sutter wrote: > Linux version 3.1 introduced a consistency check for netlink dumps in > commit 670dc28 ("netlink: advertise incomplete dumps"). This bites The scripts/checkpatch.pl now enforces 12-digit commit ID... > iproute2 when flushing more addresses than can fit into a single > RTM_GETADDR response. To silence the spurious error message "Dump was > interrupted and may be inconsistent.", advise rtnl_dump_filter_l() to > not care about NLM_F_DUMP_INTR. > > Signed-off-by: Phil Sutter <phil@nwl.cc> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/09/2015 09:51 PM, Sergei Shtylyov wrote: >> Linux version 3.1 introduced a consistency check for netlink dumps in >> commit 670dc28 ("netlink: advertise incomplete dumps"). This bites > > The scripts/checkpatch.pl now enforces 12-digit commit ID... Sorry, didn't realize it wasn't a kernel patch. :-) >> iproute2 when flushing more addresses than can fit into a single >> RTM_GETADDR response. To silence the spurious error message "Dump was >> interrupted and may be inconsistent.", advise rtnl_dump_filter_l() to >> not care about NLM_F_DUMP_INTR. >> >> Signed-off-by: Phil Sutter <phil@nwl.cc> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 09, 2015 at 09:58:50PM +0300, Sergei Shtylyov wrote: > On 11/09/2015 09:51 PM, Sergei Shtylyov wrote: > > >> Linux version 3.1 introduced a consistency check for netlink dumps in > >> commit 670dc28 ("netlink: advertise incomplete dumps"). This bites > > > > The scripts/checkpatch.pl now enforces 12-digit commit ID... > > Sorry, didn't realize it wasn't a kernel patch. :-) Heh, no problem! If more projects used checkpatch.pl, the world would be a better place. My quoting commits was usually a matter of copying what 'git --oneline show' outputs. Thanks for the heads-up, I've adjusted core.abbrev now. Cheers, Phil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ip/ipaddress.c b/ip/ipaddress.c index b5b444b..23e0308 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -1398,7 +1398,8 @@ static int ipaddr_flush(void) exit(1); } filter.flushed = 0; - if (rtnl_dump_filter(&rth, print_addrinfo, stdout) < 0) { + if (rtnl_dump_filter_nc(&rth, print_addrinfo, + stdout, NLM_F_DUMP_INTR) < 0) { fprintf(stderr, "Flush terminated\n"); exit(1); }
Linux version 3.1 introduced a consistency check for netlink dumps in commit 670dc28 ("netlink: advertise incomplete dumps"). This bites iproute2 when flushing more addresses than can fit into a single RTM_GETADDR response. To silence the spurious error message "Dump was interrupted and may be inconsistent.", advise rtnl_dump_filter_l() to not care about NLM_F_DUMP_INTR. Signed-off-by: Phil Sutter <phil@nwl.cc> --- ip/ipaddress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)