| Message ID | 1447004673-18164-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
Bernd, All, On 2015-11-08 18:44 +0100, Bernd Kuhls spake thusly: > configure.ac is not cross-compile aware, a patch fixing DRI detection > was added in 2009 > http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2 > > assuming DRI support being present if DRI support was not disabled. > > By default configure.ac assumes "auto" which leads to DRI support being > enabled even if DRI support is disabled in buildroot config. This patch > adds --disable-dri to really disable DRI support, fixes: Is this patch still applicable? Regards, Yann E. MORIN. > http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/ > http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/ > http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/ > http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/ > http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/ > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk b/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk > index dcf751c..771ec18 100644 > --- a/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk > +++ b/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk > @@ -12,4 +12,8 @@ XDRIVER_XF86_VIDEO_MGA_LICENSE_FILES = COPYING > XDRIVER_XF86_VIDEO_MGA_AUTORECONF = YES > XDRIVER_XF86_VIDEO_MGA_DEPENDENCIES = xserver_xorg-server libdrm xproto_fontsproto xproto_glproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xf86driproto xproto_xproto > > +ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),) > +XDRIVER_XF86_VIDEO_MGA_CONF_OPTS = --disable-dri > +endif > + > $(eval $(autotools-package)) > -- > 2.6.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Am Tue, 19 Apr 2016 23:47:02 +0200 schrieb Yann E. MORIN:
> Is this patch still applicable?
Hi Yann,
yes, the bug still occurs:
http://autobuild.buildroot.net/
results/8ae/8aec759b0e485b2c90e2a26d60c7776c2684c44a//
and is still fixed by my patch.
Regards, Bernd
Hello, On Sun, 8 Nov 2015 18:44:32 +0100, Bernd Kuhls wrote: > configure.ac is not cross-compile aware, a patch fixing DRI detection > was added in 2009 > http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2 > > assuming DRI support being present if DRI support was not disabled. > > By default configure.ac assumes "auto" which leads to DRI support being > enabled even if DRI support is disabled in buildroot config. This patch > adds --disable-dri to really disable DRI support, fixes: > > http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/ > http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/ > http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/ > http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/ > http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/ > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++ > 1 file changed, 4 insertions(+) Applied to next, thanks. Thomas
diff --git a/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk b/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk index dcf751c..771ec18 100644 --- a/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk +++ b/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk @@ -12,4 +12,8 @@ XDRIVER_XF86_VIDEO_MGA_LICENSE_FILES = COPYING XDRIVER_XF86_VIDEO_MGA_AUTORECONF = YES XDRIVER_XF86_VIDEO_MGA_DEPENDENCIES = xserver_xorg-server libdrm xproto_fontsproto xproto_glproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xf86driproto xproto_xproto +ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),) +XDRIVER_XF86_VIDEO_MGA_CONF_OPTS = --disable-dri +endif + $(eval $(autotools-package))
configure.ac is not cross-compile aware, a patch fixing DRI detection was added in 2009 http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2 assuming DRI support being present if DRI support was not disabled. By default configure.ac assumes "auto" which leads to DRI support being enabled even if DRI support is disabled in buildroot config. This patch adds --disable-dri to really disable DRI support, fixes: http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/ http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/ http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/ http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/ http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/ Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++ 1 file changed, 4 insertions(+)