Patchwork ahci: drop ATAPI_CMD constants

login
register
mail settings
Submitter Sebastian Herbszt
Date May 31, 2010, 8:56 p.m.
Message ID <1275339407$2802@local>
Download mbox | patch
Permalink /patch/54133/
State New
Headers show

Comments

Sebastian Herbszt - May 31, 2010, 8:56 p.m.
Drop not used ATAPI_CMD constants.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Alexander Graf - May 31, 2010, 9:26 p.m.
On 31.05.2010, at 22:56, Sebastian Herbszt wrote:

> Drop not used ATAPI_CMD constants.

I'd postpone that. We should get rid of _all_ ATA and ATAPI commands in ahci.c, but that'll be part of a bigger cleanup. IMHO we should reuse the IDE core for those.


Alex

Patch

diff --git a/hw/ahci.c b/hw/ahci.c
index 9987459..a024706 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -179,21 +179,6 @@  do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define ATA_CMD_WRITE_EXT	0x34	/* Write Sectores (with retries) with 48bit addressing */
 #define ATA_CMD_VRFY_EXT	0x42	/* Read Verify	(with retries)	with 48bit addressing */
 
-/*
- * ATAPI Commands
- */
-#define ATAPI_CMD_IDENT 0xA1 /* Identify AT Atachment Packed Interface Device */
-#define ATAPI_CMD_PACKET 0xA0 /* Packed Command */
-
-
-#define ATAPI_CMD_INQUIRY 0x12
-#define ATAPI_CMD_REQ_SENSE 0x03
-#define ATAPI_CMD_READ_CAP 0x25
-#define ATAPI_CMD_START_STOP 0x1B
-#define ATAPI_CMD_READ_12 0xA8
-
-
-
 typedef struct ahci_control_regs {
 	uint32_t  cap;
 	uint32_t  ghc;