Patchwork ahci: drop board_ahci constants

login
register
mail settings
Submitter Sebastian Herbszt
Date May 31, 2010, 8:12 p.m.
Message ID <1275336761$1514@local>
Download mbox | patch
Permalink /patch/54132/
State New
Headers show

Comments

Sebastian Herbszt - May 31, 2010, 8:12 p.m.
Drop not used board_ahci constants.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Alexander Graf - May 31, 2010, 8:13 p.m.
On 31.05.2010, at 22:12, Sebastian Herbszt wrote:

> Drop not used board_ahci constants.
> 
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> 
> diff --git a/hw/ahci.c b/hw/ahci.c
> index 3476cea..4090def 100644
> --- a/hw/ahci.c
> +++ b/hw/ahci.c
> @@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
> #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
> #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
> 
> -#define board_ahci                0
> -#define board_ahci_pi             1
> -#define board_ahci_vt8251         2
> -#define board_ahci_ign_iferr      3
> -#define board_ahci_sb600          4
> -

They weren't used before? Why are they there at all then?

Alex
Sebastian Herbszt - May 31, 2010, 8:21 p.m.
Alexander Graf wrote:
> On 31.05.2010, at 22:12, Sebastian Herbszt wrote:
>> Drop not used board_ahci constants.
>> 
>> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>> 
>> diff --git a/hw/ahci.c b/hw/ahci.c
>> index 3476cea..4090def 100644
>> --- a/hw/ahci.c
>> +++ b/hw/ahci.c
>> @@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
>> #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
>> #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
>> 
>> -#define board_ahci                0
>> -#define board_ahci_pi             1
>> -#define board_ahci_vt8251         2
>> -#define board_ahci_ign_iferr      3
>> -#define board_ahci_sb600          4
>> -
>
> They weren't used before? Why are they there at all then?
>
> Alex

Copy and paste from the linux kernel (ahci.c/h)?

Sebastian

Patch

diff --git a/hw/ahci.c b/hw/ahci.c
index 3476cea..4090def 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -65,12 +65,6 @@  do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
 #define RX_FIS_SDB                0x58 /* offset of SDB FIS data */
 #define RX_FIS_UNK                0x60 /* offset of Unknown FIS data */
 
-#define board_ahci                0
-#define board_ahci_pi             1
-#define board_ahci_vt8251         2
-#define board_ahci_ign_iferr      3
-#define board_ahci_sb600          4
-
 /* global controller registers */
 #define HOST_CAP                  0x00 /* host capabilities */
 #define HOST_CTL                  0x04 /* global host control */