| Message ID | 1446855055-38378-7-git-send-email-jrajahalme@nicira.com |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Nov 06, 2015 at 04:10:53PM -0800, Jarno Rajahalme wrote: > Hack around a bug in pyftpdlib that rejects EPRT connection due to > mismatching textual representation of the IPv6 address when the > address is not in the normalized format. This happens when the > control connection is mangled by Linux NAT. > > Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> I'll let someone who knows this part of the system better review this.
On 6 November 2015 at 16:10, Jarno Rajahalme <jrajahalme@nicira.com> wrote: > Hack around a bug in pyftpdlib that rejects EPRT connection due to > mismatching textual representation of the IPv6 address when the > address is not in the normalized format. This happens when the > control connection is mangled by Linux NAT. > > Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Joe Stringer <joe@ovn.org> Did you ever hear any follow up from the upstream developers on fixing this bug?
> On Nov 25, 2015, at 9:38 AM, Joe Stringer <joe@wand.net.nz> wrote: > > On 6 November 2015 at 16:10, Jarno Rajahalme <jrajahalme@nicira.com> wrote: >> Hack around a bug in pyftpdlib that rejects EPRT connection due to >> mismatching textual representation of the IPv6 address when the >> address is not in the normalized format. This happens when the >> control connection is mangled by Linux NAT. >> >> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> > > Acked-by: Joe Stringer <joe@ovn.org> > > Did you ever hear any follow up from the upstream developers on fixing this bug? No. I’ll try again, though. Thanks for the review, pushed to master, Jarno
diff --git a/tests/test-l7.py b/tests/test-l7.py index faec2bc..c89fcf2 100755 --- a/tests/test-l7.py +++ b/tests/test-l7.py @@ -37,6 +37,10 @@ def get_ftpd(): class OVSFTPHandler(FTPHandler): authorizer = DummyAuthorizer() authorizer.add_anonymous("/tmp") + # Hack around a bug in pyftpdlib, which rejects EPRT + # connection due to mismatching textual representation of + # the IPv6 address. + permit_foreign_addresses = True server = [FTPServer, OVSFTPHandler, 21] except ImportError: server = None
Hack around a bug in pyftpdlib that rejects EPRT connection due to mismatching textual representation of the IPv6 address when the address is not in the normalized format. This happens when the control connection is mangled by Linux NAT. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> --- tests/test-l7.py | 4 ++++ 1 file changed, 4 insertions(+)