[1/2] buildsystem: follow libtoolize suggestions
diff mbox

Message ID 1446840034-11954-2-git-send-email-alexander.huemer@xx.vu
State Changes Requested
Headers show

Commit Message

Alexander Huemer Nov. 6, 2015, 8 p.m. UTC
---
 .gitignore   | 2 ++
 Makefile.am  | 1 +
 configure.ac | 2 ++
 m4/DUMMY     | 0
 4 files changed, 5 insertions(+)
 create mode 100644 m4/DUMMY

diff --git a/m4/DUMMY b/m4/DUMMY
new file mode 100644
index 0000000..e69de29

Comments

Holger Freyther Nov. 7, 2015, 11:45 a.m. UTC | #1
> On 06 Nov 2015, at 21:00, Alexander Huemer <alexander.huemer@xx.vu> wrote:
> 

Well, we don't have any m4 macros ourselves and just creating an empty directory doesn't
look like a good idea. Have you considered asking on the libtool/autoconf list where this
warning is coming from and what to do about it?

thanks
	holger
Alexander Huemer Nov. 7, 2015, 1:07 p.m. UTC | #2
Hi!

On Sat, Nov 07, 2015 at 12:45:33PM +0100, Holger Freyther wrote:
> > On 06 Nov 2015, at 21:00, Alexander Huemer <alexander.huemer@xx.vu> wrote:
> 
> Well, we don't have any m4 macros ourselves and just creating an empty directory doesn't
> look like a good idea. Have you considered asking on the libtool/autoconf list where this
> warning is coming from and what to do about it?

Are you sure this approach is wrong?
In libosmocore the same was done in commit 
b2eb83fa95b209fb01de2996a1382c944fc265fe of 2010, I actually took the 
filename from there.
If you prefer I can check with the autotools people.

Kind regards,
-Alex
Holger Freyther Jan. 15, 2016, 2:37 p.m. UTC | #3
> On 07 Nov 2015, at 14:07, Alexander Huemer <alexander.huemer@xx.vu> wrote:
> 
> Hi!
> 
> On Sat, Nov 07, 2015 at 12:45:33PM +0100, Holger Freyther wrote:
>>> On 06 Nov 2015, at 21:00, Alexander Huemer <alexander.huemer@xx.vu> wrote:
>> 
>> Well, we don't have any m4 macros ourselves and just creating an empty directory doesn't
>> look like a good idea. Have you considered asking on the libtool/autoconf list where this
>> warning is coming from and what to do about it?
> 
> Are you sure this approach is wrong?
> In libosmocore the same was done in commit 
> b2eb83fa95b209fb01de2996a1382c944fc265fe of 2010, I actually took the 
> filename from there.
> If you prefer I can check with the autotools people.

yes, please. I mean why do we create a m4/DUMMY just to fix a suggestion by a tool? It
shows that we don't have a need for this directory right now?
Alexander Huemer Jan. 15, 2016, 3:22 p.m. UTC | #4
On Fri, Jan 15, 2016 at 03:37:27PM +0100, Holger Freyther wrote:
> 
> > On 07 Nov 2015, at 14:07, Alexander Huemer <alexander.huemer@xx.vu> wrote:
> > 
> > Hi!
> > 
> > On Sat, Nov 07, 2015 at 12:45:33PM +0100, Holger Freyther wrote:
> >>> On 06 Nov 2015, at 21:00, Alexander Huemer <alexander.huemer@xx.vu> wrote:
> >> 
> >> Well, we don't have any m4 macros ourselves and just creating an empty directory doesn't
> >> look like a good idea. Have you considered asking on the libtool/autoconf list where this
> >> warning is coming from and what to do about it?
> > 
> > Are you sure this approach is wrong?
> > In libosmocore the same was done in commit 
> > b2eb83fa95b209fb01de2996a1382c944fc265fe of 2010, I actually took the 
> > filename from there.
> > If you prefer I can check with the autotools people.
> 
> yes, please. I mean why do we create a m4/DUMMY just to fix a suggestion by a tool? It
> shows that we don't have a need for this directory right now?

As I see the situation the approach is exactly that.
Adding a file that does not hurt to make the tool happy.
There are no other consequences.
If you prefer to keep the repository clean of files and directories
that do not add functionality, that's a of course a approach as well.

BTW, I asked on the freenode#autotools channel back in November,
the guys there told me the same thing.

Kind regards,
-Alex

Patch
diff mbox

diff --git a/.gitignore b/.gitignore
index 6cc9aa5..93bd908 100644
--- a/.gitignore
+++ b/.gitignore
@@ -18,6 +18,8 @@  install-sh
 missing
 libtool
 ltmain.sh
+m4/*.m4
+compile
 
 core
 core.*
diff --git a/Makefile.am b/Makefile.am
index 4cbc114..80ecaac 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,3 +1,4 @@ 
+ACLOCAL_AMFLAGS = -I m4
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
 
 SUBDIRS = src examples tests
diff --git a/configure.ac b/configure.ac
index 876f7d4..eabb2e7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,6 +16,8 @@  AC_PROG_CXX
 AC_PROG_INSTALL
 LT_INIT
 
+AC_CONFIG_MACRO_DIR([m4])
+
 dnl checks for header files
 AC_HEADER_STDC