diff mbox

[Vivid] UBUNTU: SAUCE: net: usb: cdc_ether: add DW5580 as a mobile broadband adapter

Message ID 1446820210-22740-1-git-send-email-jesse.sung@canonical.com
State New
Headers show

Commit Message

Wen-chien Jesse Sung Nov. 6, 2015, 2:30 p.m. UTC
From: danielepa <daniele.palmas@telit.com>

BugLink: https://launchpad.net/bugs/1513847

Signed-off-by: danielepa <daniele.palmas@telit.com>
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
Tested-by: Gavin Lin <gavin.lin@canonical.com>
Reviewed-by: Keng-Yu Lin <kengyu@canonical.com>
---
 drivers/net/usb/cdc_ether.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Tim Gardner Nov. 6, 2015, 2:44 p.m. UTC | #1
On 11/06/2015 08:30 AM, Wen-chien Jesse Sung wrote:
> From: danielepa <daniele.palmas@telit.com>
> 
> BugLink: https://launchpad.net/bugs/1513847
> 
> Signed-off-by: danielepa <daniele.palmas@telit.com>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
> Tested-by: Gavin Lin <gavin.lin@canonical.com>
> Reviewed-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>  drivers/net/usb/cdc_ether.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
> index 9311a08..21d27bd 100644
> --- a/drivers/net/usb/cdc_ether.c
> +++ b/drivers/net/usb/cdc_ether.c
> @@ -748,6 +748,11 @@ static const struct usb_device_id	products[] = {
>  			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
>  	.driver_info = (kernel_ulong_t) &wwan_info,
>  }, {
> +	/* Dell DW5580 modules */
> +	USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x81ba, USB_CLASS_COMM,
> +			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
> +	.driver_info = (kernel_ulong_t) &wwan_info,
> +}, {
>  	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
>  			USB_CDC_PROTO_NONE),
>  	.driver_info = (unsigned long) &cdc_info,
> 

How about Wily and Xenial ?
Brad Figg Nov. 6, 2015, 8:10 p.m. UTC | #2
Applied to the master-next branch of Vivid.
Wen-chien Jesse Sung Nov. 25, 2015, 10:25 a.m. UTC | #3
2015-11-06 22:44 GMT+08:00 Tim Gardner <tim.gardner@canonical.com>:
> On 11/06/2015 08:30 AM, Wen-chien Jesse Sung wrote:
>> From: danielepa <daniele.palmas@telit.com>
>>
>> BugLink: https://launchpad.net/bugs/1513847
>>
>> Signed-off-by: danielepa <daniele.palmas@telit.com>
>> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
>> Tested-by: Gavin Lin <gavin.lin@canonical.com>
>> Reviewed-by: Keng-Yu Lin <kengyu@canonical.com>
>> ---
>>  drivers/net/usb/cdc_ether.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
>> index 9311a08..21d27bd 100644
>> --- a/drivers/net/usb/cdc_ether.c
>> +++ b/drivers/net/usb/cdc_ether.c
>> @@ -748,6 +748,11 @@ static const struct usb_device_id        products[] = {
>>                       USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
>>       .driver_info = (kernel_ulong_t) &wwan_info,
>>  }, {
>> +     /* Dell DW5580 modules */
>> +     USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x81ba, USB_CLASS_COMM,
>> +                     USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
>> +     .driver_info = (kernel_ulong_t) &wwan_info,
>> +}, {
>>       USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
>>                       USB_CDC_PROTO_NONE),
>>       .driver_info = (unsigned long) &cdc_info,
>>
>
> How about Wily and Xenial ?

This patch is sent to vivid due to a tight schedule of the project.
Let's see what's Telit's plan for
sending it to upstream, and then we can pull it into Wily and Xenial from there.

>
> --
> Tim Gardner tim.gardner@canonical.com

Thanks,
Jesse
Daniele Palmas Nov. 25, 2015, 10:32 a.m. UTC | #4
Hello,

already sent upstream, it should be present in 4.4-rc2.

https://lkml.org/lkml/2015/11/22/207

Thanks,
Daniele

-----Original Message-----
From: Jesse Sung [mailto:jesse.sung@canonical.com] 
Sent: mercoledì 25 novembre 2015 11:26
To: Tim Gardner <tim.gardner@canonical.com>
Cc: kernel-team@lists.ubuntu.com; Daniele Palmas <Daniele.Palmas@telit.com>; alex.kaluzhny@canonical.com
Subject: Re: ACK: [Vivid][PATCH] UBUNTU: SAUCE: net: usb: cdc_ether: add DW5580 as a mobile broadband adapter

2015-11-06 22:44 GMT+08:00 Tim Gardner <tim.gardner@canonical.com>:
> On 11/06/2015 08:30 AM, Wen-chien Jesse Sung wrote:
>> From: danielepa <daniele.palmas@telit.com>
>>
>> BugLink: https://launchpad.net/bugs/1513847
>>
>> Signed-off-by: danielepa <daniele.palmas@telit.com>
>> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
>> Tested-by: Gavin Lin <gavin.lin@canonical.com>
>> Reviewed-by: Keng-Yu Lin <kengyu@canonical.com>
>> ---
>>  drivers/net/usb/cdc_ether.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/usb/cdc_ether.c 
>> b/drivers/net/usb/cdc_ether.c index 9311a08..21d27bd 100644
>> --- a/drivers/net/usb/cdc_ether.c
>> +++ b/drivers/net/usb/cdc_ether.c
>> @@ -748,6 +748,11 @@ static const struct usb_device_id        products[] = {
>>                       USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
>>       .driver_info = (kernel_ulong_t) &wwan_info,  }, {
>> +     /* Dell DW5580 modules */
>> +     USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x81ba, USB_CLASS_COMM,
>> +                     USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
>> +     .driver_info = (kernel_ulong_t) &wwan_info, }, {
>>       USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
>>                       USB_CDC_PROTO_NONE),
>>       .driver_info = (unsigned long) &cdc_info,
>>
>
> How about Wily and Xenial ?

This patch is sent to vivid due to a tight schedule of the project.
Let's see what's Telit's plan for
sending it to upstream, and then we can pull it into Wily and Xenial from there.

>
> --
> Tim Gardner tim.gardner@canonical.com

Thanks,
Jesse
Wen-chien Jesse Sung Nov. 25, 2015, 12:02 p.m. UTC | #5
2015-11-25 18:32 GMT+08:00 Daniele Palmas <Daniele.Palmas@telit.com>:
>
> Hello,
>
> already sent upstream, it should be present in 4.4-rc2.
>
> https://lkml.org/lkml/2015/11/22/207

Cool, it's in mainline now. So we'll have it in Xenial.
I'll generate a patch for Wily.

Thanks,
Jesse

>
> Thanks,
> Daniele
>
> -
>
>  Daniele Palmas
>  Drivers Team Leader, R&D
>   Officee +39 070 4603 247
> Mobile  +39 335 264 592
> Email    daniele.palmas@telit.com
>   www.telit.com
>
>
> This electronic message, including attachments, is intended only for the use of the individual or company named above or to which it is addressed. The information contained in this message shall be considered confidential and proprietary, and may include confidential work product. If you are not the intended recipient, please be aware that any unauthorized use, dissemination, distribution or copying of this message is strictly prohibited. If you have received this email in error, please notify the sender by replying to this message and deleting this email immediately.
>
> To the extent this email includes an offer to buy Telit products or an order confirmation, the offer or order confirmation is governed by Telit’s General Terms and Conditions of Sale, which are published here.
>
> ________________________________
>
> ----Original Message-----
> From: Jesse Sung [mailto:jesse.sung@canonical.com]
> Sent: mercoledì 25 novembre 2015 11:26
> To: Tim Gardner
> Cc: kernel-team@lists.ubuntu.com; Daniele Palmas ; alex.kaluzhny@canonical.com
> Subject: Re: ACK: [Vivid][PATCH] UBUNTU: SAUCE: net: usb: cdc_ether: add DW5580 as a mobile broadband adapter
>
> 2015-11-06 22:44 GMT+08:00 Tim Gardner :
> > On 11/06/2015 08:30 AM, Wen-chien Jesse Sung wrote:
> >> From: danielepa
> >>
> >> BugLink: https://launchpad.net/bugs/1513847
> >>
> >> Signed-off-by: danielepa
> >> Signed-off-by: Wen-chien Jesse Sung
> >> Tested-by: Gavin Lin
> >> Reviewed-by: Keng-Yu Lin
> >> ---
> >> drivers/net/usb/cdc_ether.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/drivers/net/usb/cdc_ether.c
> >> b/drivers/net/usb/cdc_ether.c index 9311a08..21d27bd 100644
> >> --- a/drivers/net/usb/cdc_ether.c
> >> +++ b/drivers/net/usb/cdc_ether.c
> >> @@ -748,6 +748,11 @@ static const struct usb_device_id products[] = {
> >> USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
> >> .driver_info = (kernel_ulong_t) &wwan_info, }, {
> >> + /* Dell DW5580 modules */
> >> + USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x81ba, USB_CLASS_COMM,
> >> + USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
> >> + .driver_info = (kernel_ulong_t) &wwan_info, }, {
> >> USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
> >> USB_CDC_PROTO_NONE),
> >> .driver_info = (unsigned long) &cdc_info,
> >>
> >
> > How about Wily and Xenial ?
>
> This patch is sent to vivid due to a tight schedule of the project.
> Let's see what's Telit's plan for
> sending it to upstream, and then we can pull it into Wily and Xenial from there.
>
> >
> > --
> > Tim Gardner tim.gardner@canonical.com
>
> Thanks,
> Jesse
diff mbox

Patch

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 9311a08..21d27bd 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -748,6 +748,11 @@  static const struct usb_device_id	products[] = {
 			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
 	.driver_info = (kernel_ulong_t) &wwan_info,
 }, {
+	/* Dell DW5580 modules */
+	USB_DEVICE_AND_INTERFACE_INFO(DELL_VENDOR_ID, 0x81ba, USB_CLASS_COMM,
+			USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
+	.driver_info = (kernel_ulong_t) &wwan_info,
+}, {
 	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
 			USB_CDC_PROTO_NONE),
 	.driver_info = (unsigned long) &cdc_info,