| Message ID | 1446658240-31423-1-git-send-email-sd@queasysnail.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2015-11-04 at 18:30 +0100, Sabrina Dubroca wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > Call snmp6_unregister_dev in this case. > > Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default") > Reported-by: Dmitry Vyukov <dvyukov@google.com> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> > --- Acked-by: Eric Dumazet <edumazet@google.com> Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 4, 2015 at 9:30 AM, Sabrina Dubroca <sd@queasysnail.net> wrote: > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up > the dev_snmp6 entry that we have already registered for this device. > Call snmp6_unregister_dev in this case. > > Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default") > Reported-by: Dmitry Vyukov <dvyukov@google.com> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Reviewed-by: Cong Wang <cwang@twopensource.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 36b85bd05ac8..dd00828863a0 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -417,6 +417,7 @@ static struct inet6_dev *ipv6_add_dev(struct net_device *dev) if (err) { ipv6_mc_destroy_dev(ndev); del_timer(&ndev->regen_timer); + snmp6_unregister_dev(ndev); goto err_release; } /* protected by rtnl_lock */
In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up the dev_snmp6 entry that we have already registered for this device. Call snmp6_unregister_dev in this case. Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default") Reported-by: Dmitry Vyukov <dvyukov@google.com> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> --- v4: v3 had a bad message-id and didn't get picked up by patchwork, sorry for the noise v3: add Fixes: tag, thanks Eric. v2: we cannot call snmp6_unregister_dev from addrconf_core.c, this breaks CONFIG_IPV6=m, instead do the clean up directly from ipv6_add_dev thanks Cong. net/ipv6/addrconf.c | 1 + 1 file changed, 1 insertion(+)