From patchwork Sun May 30 14:00:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Richter X-Patchwork-Id: 53999 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E7A46B6EEB for ; Mon, 31 May 2010 00:09:17 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271Ab0E3OJQ (ORCPT ); Sun, 30 May 2010 10:09:16 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:57885 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983Ab0E3OJP (ORCPT ); Sun, 30 May 2010 10:09:15 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Received: from stein ([83.221.231.7]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id o4UE92vo018173; Sun, 30 May 2010 16:09:03 +0200 Date: Sun, 30 May 2010 16:00:18 +0200 (CEST) From: Stefan Richter Subject: [PATCH] libata-sff: clarification and trivial correction to Kconfig text To: linux-ide@vger.kernel.org cc: Jeff Garzik , Tejun Heo , linux-doc@vger.kernel.org In-Reply-To: <4C0225D1.90205@kernel.org> Message-ID: References: <4C010AA8.8070004@kernel.org> <4C0135BF.1010505@s5r6.in-berlin.de> <4C0225D1.90205@kernel.org> MIME-Version: 1.0 Content-Disposition: INLINE X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Change the text of the ATA_BMDMA prompt to indicate that it lets one access a class of device drivers (rather than only add a certain feature to libata). The divisions of the "ATA SFF support" menu now read - SFF controllers with custom DMA interface, - SFF controllers with bus master DMA (was: "ATA BMDMA support"), - SATA SFF controllers with BMDMA, - PATA SFF controllers with BMDMA, - PIO-only SFF controllers. This hopefully helps convince users of "make oldconfig" to follow the recommendation to switch that option on. Also let the help text of this prompt say more precisely what it is about: It adds a little bit of support code to libata that is required by many but not all SFF drivers. This option alone does not add support of respective controllers though; according drivers are chosen at subsequent dependent Kconfig prompts. --- And fix a typo. Signed-off-by: Stefan Richter Acked-by: Tejun Heo --- Supersedes patch "libata-sff: trivial corrections to Kconfig help text". drivers/ata/Kconfig | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 73f8833..31e288b 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -164,14 +164,14 @@ config SATA_SX4 If unsure, say N. config ATA_BMDMA - bool "ATA BMDMA support" + bool "SFF controllers with bus master DMA" default y help - This option adds support for SFF ATA controllers with BMDMA - capability. BMDMA stands for bus-master DMA and the - de-facto DMA interface for SFF controllers. + This option is required by drivers of SFF ATA controllers with + BMDMA capability. BMDMA stands for bus master DMA and is the + de facto DMA interface for SFF controllers. - If unuser, say Y. + If unsure, say Y. if ATA_BMDMA