Patchwork libata-sff: clarification and trivial correction to Kconfig text

login
register
mail settings
Submitter Stefan Richter
Date May 30, 2010, 2 p.m.
Message ID <tkrat.acb772e71ffffd6e@s5r6.in-berlin.de>
Download mbox | patch
Permalink /patch/53999/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Stefan Richter - May 30, 2010, 2 p.m.
Change the text of the ATA_BMDMA prompt to indicate that it lets one access a class of
device drivers (rather than only add a certain feature to libata).  The divisions of
the "ATA SFF support" menu now read
  - SFF controllers with custom DMA interface,
  - SFF controllers with bus master DMA  (was: "ATA BMDMA support"),
      - SATA SFF controllers with BMDMA,
      - PATA SFF controllers with BMDMA,
  - PIO-only SFF controllers.
This hopefully helps convince users of "make oldconfig" to follow the
recommendation to switch that option on.

Also let the help text of this prompt say more precisely what it is about:  It adds a
little bit of support code to libata that is required by many but not all SFF drivers.
This option alone does not add support of respective controllers though; according
drivers are chosen at subsequent dependent Kconfig prompts. --- And fix a typo.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Supersedes patch "libata-sff: trivial corrections to Kconfig help text".

 drivers/ata/Kconfig |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
Tejun Heo - May 30, 2010, 3:05 p.m.
On 05/30/2010 04:00 PM, Stefan Richter wrote:
> Change the text of the ATA_BMDMA prompt to indicate that it lets one access a class of
> device drivers (rather than only add a certain feature to libata).  The divisions of
> the "ATA SFF support" menu now read
>   - SFF controllers with custom DMA interface,
>   - SFF controllers with bus master DMA  (was: "ATA BMDMA support"),
>       - SATA SFF controllers with BMDMA,
>       - PATA SFF controllers with BMDMA,
>   - PIO-only SFF controllers.
> This hopefully helps convince users of "make oldconfig" to follow the
> recommendation to switch that option on.
> 
> Also let the help text of this prompt say more precisely what it is about:  It adds a
> little bit of support code to libata that is required by many but not all SFF drivers.
> This option alone does not add support of respective controllers though; according
> drivers are chosen at subsequent dependent Kconfig prompts. --- And fix a typo.
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 73f8833..31e288b 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -164,14 +164,14 @@  config SATA_SX4
 	  If unsure, say N.
 
 config ATA_BMDMA
-	bool "ATA BMDMA support"
+	bool "SFF controllers with bus master DMA"
 	default y
 	help
-	  This option adds support for SFF ATA controllers with BMDMA
-	  capability.  BMDMA stands for bus-master DMA and the
-	  de-facto DMA interface for SFF controllers.
+	  This option is required by drivers of SFF ATA controllers with
+	  BMDMA capability.  BMDMA stands for bus master DMA and is the
+	  de facto DMA interface for SFF controllers.
 
-	  If unuser, say Y.
+	  If unsure, say Y.
 
 if ATA_BMDMA