diff mbox

[U-Boot] Pull request: u-boot-spi/next

Message ID CAOMZO5BE03v6qK6NzM1N5XV9o4pwLgahYUFW-i-naFa0d9gQcQ@mail.gmail.com
State RFC
Delegated to: Tom Rini
Headers show

Commit Message

Fabio Estevam Nov. 4, 2015, 10:46 a.m. UTC 
Hi Tom,

On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>
>> NAK.
>>
>> So, this blows up badly for a lot of things when I do:
>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>
> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.

I don't see issues after applying the three attached patches.

Thanks
From 09b289e8a372b21d1ffe0c1484d1bb3c392e01c3 Mon Sep 17 00:00:00 2001
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Wed, 4 Nov 2015 08:35:02 -0200
Subject: [PATCH 1/3] mips: Use the generic bitops headers

The generic bitops headers are required when calling logarithimic
functions, such as ilog2().

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/mips/include/asm/bitops.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Fabio Estevam Nov. 4, 2015, 10:47 a.m. UTC | #1 
On Wed, Nov 4, 2015 at 8:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Tom,
>
> On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>>
>>> NAK.
>>>
>>> So, this blows up badly for a lot of things when I do:
>>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>>
>> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.
>
> I don't see issues after applying the three attached patches.

Ops, I do see a build issue in blackfin that didn't happen in previous
versions. Will work on fixing it.
diff mbox

Patch

diff --git a/arch/mips/include/asm/bitops.h b/arch/mips/include/asm/bitops.h
index b5c2a63..c31ff6e 100644
--- a/arch/mips/include/asm/bitops.h
+++ b/arch/mips/include/asm/bitops.h
@@ -17,6 +17,11 @@ 
 #include <asm/sgidefs.h>
 #include <asm/system.h>
 
+#include <asm-generic/bitops/fls.h>
+#include <asm-generic/bitops/__fls.h>
+#include <asm-generic/bitops/fls64.h>
+#include <asm-generic/bitops/__ffs.h>
+
 /*
  * clear_bit() doesn't provide any barrier for the compiler.
  */