diff mbox

[U-Boot,3/6] net: altera_tse: fix CamelCase

Message ID 1446628349-26749-3-git-send-email-thomas@wytron.com.tw
State Superseded
Headers show

Commit Message

Thomas Chou Nov. 4, 2015, 9:12 a.m. UTC
fix CamelCase.

CHECK: Avoid CamelCase: <aMACID_1>
#170: FILE: drivers/net/altera_tse.h:170:
+	u32 aMACID_1;	/*The MAC addresses */

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
 drivers/net/altera_tse.h | 81 ++++++++++++++++++++++++------------------------
 1 file changed, 41 insertions(+), 40 deletions(-)

Comments

Chin Liang See Nov. 4, 2015, 4:17 p.m. UTC | #1
Hi Thomas,


On Wed, 2015-11-04 at 17:12 +0800, thomas@wytron.com.tw wrote:
> fix CamelCase.
> 
> CHECK: Avoid CamelCase: <aMACID_1>
> #170: FILE: drivers/net/altera_tse.h:170:
> +	u32 aMACID_1;	/*The MAC addresses */
> 
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>  drivers/net/altera_tse.h | 81 ++++++++++++++++++++++++------------------------
>  1 file changed, 41 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/net/altera_tse.h b/drivers/net/altera_tse.h
> index 7b92b12..1652e40 100644
> --- a/drivers/net/altera_tse.h
> +++ b/drivers/net/altera_tse.h
> @@ -167,57 +167,58 @@ struct alt_tse_mac {
>  	u32 min_tx_ipg_length;
>  
>  	/* IEEE 802.3 oEntity Managed Object Support */
> -	u32 aMACID_1;	/*The MAC addresses */
> -	u32 aMACID_2;
> -	u32 aFramesTransmittedOK;
> -	u32 aFramesReceivedOK;
> -	u32 aFramesCheckSequenceErrors;
> -	u32 aAlignmentErrors;
> -	u32 aOctetsTransmittedOK;
> -	u32 aOctetsReceivedOK;
> +	u32 mac_id_1;
> +	u32 mac_id_2;
> +	u32 frames_transmitted_ok;
> +	u32 frames_received_ok;
> +	u32 frames_check_sequence_errors;
> +	u32 alignment_errors;
> +	u32 octets_transmitted_ok;
> +	u32 octets_received_ok;
>  
>  	/* IEEE 802.3 oPausedEntity Managed Object Support */
> -	u32 aTxPAUSEMACCtrlFrames;
> -	u32 aRxPAUSEMACCtrlFrames;
> +	u32 tx_pause_mac_ctrl_frames;
> +	u32 rx_pause_mac_ctrl_frames;
>  
>  	/* IETF MIB (MIB-II) Object Support */
> -	u32 ifInErrors;
> -	u32 ifOutErrors;
> -	u32 ifInUcastPkts;
> -	u32 ifInMulticastPkts;
> -	u32 ifInBroadcastPkts;
> -	u32 ifOutDiscards;
> -	u32 ifOutUcastPkts;
> -	u32 ifOutMulticastPkts;
> -	u32 ifOutBroadcastPkts;
> +	u32 if_in_errors;
> +	u32 if_out_errors;
> +	u32 if_in_ucast_pkts;
> +	u32 if_in_multicast_pkts;
> +	u32 if_in_broadcast_pkts;
> +	u32 if_out_discards;
> +	u32 if_out_ucast_pkts;
> +	u32 if_out_multicast_pkts;
> +	u32 if_out_broadcast_pkts;
>  
>  	/* IETF RMON MIB Object Support */
> -	u32 etherStatsDropEvent;
> -	u32 etherStatsOctets;
> -	u32 etherStatsPkts;
> -	u32 etherStatsUndersizePkts;
> -	u32 etherStatsOversizePkts;
> -	u32 etherStatsPkts64Octets;
> -	u32 etherStatsPkts65to127Octets;
> -	u32 etherStatsPkts128to255Octets;
> -	u32 etherStatsPkts256to511Octets;
> -	u32 etherStatsPkts512to1023Octets;
> -	u32 etherStatsPkts1024to1518Octets;
> -
> -	u32 etherStatsPkts1519toXOctets;
> -	u32 etherStatsJabbers;
> -	u32 etherStatsFragments;
> -
> -	u32 reservedxE4;
> +	u32 ether_stats_drop_events;
> +	u32 ether_stats_octets;
> +	u32 ether_stats_pkts;
> +	u32 ether_stats_undersize_pkts;
> +	u32 ether_stats_oversize_pkts;
> +	u32 ether_stats_pkts_64_octets;
> +	u32 ether_stats_pkts_65to127_octets;
> +	u32 ether_stats_pkts_128to255_octets;
> +	u32 ether_stats_pkts_256to511_octets;
> +	u32 ether_stats_pkts_512to1023_octets;
> +	u32 ether_stats_pkts_1024to1518_octets;
> +	u32 ether_stats_pkts_1519tox_octets;
> +	u32 ether_stats_jabbers;
> +	u32 ether_stats_fragments;
> +
> +	u32 reserved2;
>  
>  	/*FIFO control register. */
>  	u32 tx_cmd_stat;
>  	u32 rx_cmd_stat;
>  
> -	u32 ipaccTxConf;
> -	u32 ipaccRxConf;
> -	u32 ipaccRxStat;
> -	u32 ipaccRxStatSum;
> +	/* Extended Statistics Counters */
> +	u32 msb_octets_transmitted_ok;
> +	u32 msb_octets_received_ok;
> +	u32 msb_ether_stats_octets;
> +
> +	u32 reserved3;
>  
>  	/*Multicast address resolution table */
>  	u32 hash_table[64];

It seems these declaration are not used in the altera_tse.c.

Thanks
Chin Liang
Thomas Chou Nov. 5, 2015, 1:30 p.m. UTC | #2
Hi Chin Liang,

On 2015年11月05日 00:17, Chin Liang See wrote:
> It seems these declaration are not used in the altera_tse.c.

Thanks a lot for your review. I have removed those mac reg def not used 
in the altera_tse.c.

Best regards,
Thomas
diff mbox

Patch

diff --git a/drivers/net/altera_tse.h b/drivers/net/altera_tse.h
index 7b92b12..1652e40 100644
--- a/drivers/net/altera_tse.h
+++ b/drivers/net/altera_tse.h
@@ -167,57 +167,58 @@  struct alt_tse_mac {
 	u32 min_tx_ipg_length;
 
 	/* IEEE 802.3 oEntity Managed Object Support */
-	u32 aMACID_1;	/*The MAC addresses */
-	u32 aMACID_2;
-	u32 aFramesTransmittedOK;
-	u32 aFramesReceivedOK;
-	u32 aFramesCheckSequenceErrors;
-	u32 aAlignmentErrors;
-	u32 aOctetsTransmittedOK;
-	u32 aOctetsReceivedOK;
+	u32 mac_id_1;
+	u32 mac_id_2;
+	u32 frames_transmitted_ok;
+	u32 frames_received_ok;
+	u32 frames_check_sequence_errors;
+	u32 alignment_errors;
+	u32 octets_transmitted_ok;
+	u32 octets_received_ok;
 
 	/* IEEE 802.3 oPausedEntity Managed Object Support */
-	u32 aTxPAUSEMACCtrlFrames;
-	u32 aRxPAUSEMACCtrlFrames;
+	u32 tx_pause_mac_ctrl_frames;
+	u32 rx_pause_mac_ctrl_frames;
 
 	/* IETF MIB (MIB-II) Object Support */
-	u32 ifInErrors;
-	u32 ifOutErrors;
-	u32 ifInUcastPkts;
-	u32 ifInMulticastPkts;
-	u32 ifInBroadcastPkts;
-	u32 ifOutDiscards;
-	u32 ifOutUcastPkts;
-	u32 ifOutMulticastPkts;
-	u32 ifOutBroadcastPkts;
+	u32 if_in_errors;
+	u32 if_out_errors;
+	u32 if_in_ucast_pkts;
+	u32 if_in_multicast_pkts;
+	u32 if_in_broadcast_pkts;
+	u32 if_out_discards;
+	u32 if_out_ucast_pkts;
+	u32 if_out_multicast_pkts;
+	u32 if_out_broadcast_pkts;
 
 	/* IETF RMON MIB Object Support */
-	u32 etherStatsDropEvent;
-	u32 etherStatsOctets;
-	u32 etherStatsPkts;
-	u32 etherStatsUndersizePkts;
-	u32 etherStatsOversizePkts;
-	u32 etherStatsPkts64Octets;
-	u32 etherStatsPkts65to127Octets;
-	u32 etherStatsPkts128to255Octets;
-	u32 etherStatsPkts256to511Octets;
-	u32 etherStatsPkts512to1023Octets;
-	u32 etherStatsPkts1024to1518Octets;
-
-	u32 etherStatsPkts1519toXOctets;
-	u32 etherStatsJabbers;
-	u32 etherStatsFragments;
-
-	u32 reservedxE4;
+	u32 ether_stats_drop_events;
+	u32 ether_stats_octets;
+	u32 ether_stats_pkts;
+	u32 ether_stats_undersize_pkts;
+	u32 ether_stats_oversize_pkts;
+	u32 ether_stats_pkts_64_octets;
+	u32 ether_stats_pkts_65to127_octets;
+	u32 ether_stats_pkts_128to255_octets;
+	u32 ether_stats_pkts_256to511_octets;
+	u32 ether_stats_pkts_512to1023_octets;
+	u32 ether_stats_pkts_1024to1518_octets;
+	u32 ether_stats_pkts_1519tox_octets;
+	u32 ether_stats_jabbers;
+	u32 ether_stats_fragments;
+
+	u32 reserved2;
 
 	/*FIFO control register. */
 	u32 tx_cmd_stat;
 	u32 rx_cmd_stat;
 
-	u32 ipaccTxConf;
-	u32 ipaccRxConf;
-	u32 ipaccRxStat;
-	u32 ipaccRxStatSum;
+	/* Extended Statistics Counters */
+	u32 msb_octets_transmitted_ok;
+	u32 msb_octets_received_ok;
+	u32 msb_ether_stats_octets;
+
+	u32 reserved3;
 
 	/*Multicast address resolution table */
 	u32 hash_table[64];