Patchwork libata-sff: trivial corrections to Kconfig help text

login
register
mail settings
Submitter Stefan Richter
Date May 29, 2010, 10:47 a.m.
Message ID <tkrat.67c3608aed9d86ad@s5r6.in-berlin.de>
Download mbox | patch
Permalink /patch/53974/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Stefan Richter - May 29, 2010, 10:47 a.m.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/ata/Kconfig |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


By the way, is there something that could be said in a few words in the
help text when to enable that option and when not?

Or could that option even be hidden and 'select'ed by bus master DMA
capable ATA SFF drivers?
Tejun Heo - May 29, 2010, 12:38 p.m.
On 05/29/2010 12:47 PM, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Acked-by: Tejun Heo <tj@kernel.org>

> ---
>  drivers/ata/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 73f8833..aa85a98 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -168,10 +168,10 @@ config ATA_BMDMA
>  	default y
>  	help
>  	  This option adds support for SFF ATA controllers with BMDMA
> -	  capability.  BMDMA stands for bus-master DMA and the
> -	  de-facto DMA interface for SFF controllers.
> +	  capability.  BMDMA stands for bus-master DMA and is the
> +	  de facto DMA interface for SFF controllers.
>  
> -	  If unuser, say Y.
> +	  If unsure, say Y.
>  
>  if ATA_BMDMA
>  
> 
> By the way, is there something that could be said in a few words in the
> help text when to enable that option and when not?

Hmmmm... maybe we can emphasize the 'if unsure, say Y' part?

> Or could that option even be hidden and 'select'ed by bus master DMA
> capable ATA SFF drivers?

I wanted to make the distinction clear so made the option explicit.
Opinions on whether that is actually a good idea would differ but at
the same time, I don't think this would cause any problem, would it?

Thanks.
Stefan Richter - May 29, 2010, 3:41 p.m.
Tejun Heo wrote:
> On 05/29/2010 12:47 PM, Stefan Richter wrote:
>> By the way, is there something that could be said in a few words in the
>> help text when to enable that option and when not?
> 
> Hmmmm... maybe we can emphasize the 'if unsure, say Y' part?

I did follow that recommendation but was still left curious. :-)

>> Or could that option even be hidden and 'select'ed by bus master DMA
>> capable ATA SFF drivers?
> 
> I wanted to make the distinction clear so made the option explicit.
> Opinions on whether that is actually a good idea would differ but at
> the same time, I don't think this would cause any problem, would it?

OK, I first came across it by way of make oldconfig.  Then I read the
changelog and still wondered.  Now I had a look at the menu layout in
gconfig and it makes sense to me now.

Just from the looks of the menu, would calling the prompt

	bool "SFF controllers with bus master DMA"

be sensible?  After all, this option does not just control whether a
certain capability is built into libata, switching it on pulls up the
Kconfig prompts for a whole range of controller drivers.  (Ok, the help
text is saying exactly this, but then the prompt could do so already...)

The 'hidden variable + select' way would be more friendly to "make
oldconfig", but I see now that it would take quite a few select
statements to be added.
Tejun Heo - May 30, 2010, 8:46 a.m.
Hello,

On 05/29/2010 05:41 PM, Stefan Richter wrote:
>> Hmmmm... maybe we can emphasize the 'if unsure, say Y' part?
> 
> I did follow that recommendation but was still left curious. :-)

Maybe it should be changed to "You're supposed to be unsure, say Y,
dammit!" :-)

>>> Or could that option even be hidden and 'select'ed by bus master DMA
>>> capable ATA SFF drivers?
>>
>> I wanted to make the distinction clear so made the option explicit.
>> Opinions on whether that is actually a good idea would differ but at
>> the same time, I don't think this would cause any problem, would it?
> 
> OK, I first came across it by way of make oldconfig.  Then I read the
> changelog and still wondered.  Now I had a look at the menu layout in
> gconfig and it makes sense to me now.
> 
> Just from the looks of the menu, would calling the prompt
> 
> 	bool "SFF controllers with bus master DMA"
> 
> be sensible?  After all, this option does not just control whether a
> certain capability is built into libata, switching it on pulls up the
> Kconfig prompts for a whole range of controller drivers.  (Ok, the help
> text is saying exactly this, but then the prompt could do so already...)

Yes, sure.  Can you please combine this with the original patch?

> The 'hidden variable + select' way would be more friendly to "make
> oldconfig", but I see now that it would take quite a few select
> statements to be added.

Yeah, that and I *really* wanted to make the distinction explicit
because ambiguous dependeny has been a problem for some time.  Now a
driver will end up in a different config section which is always
visible depending on its dependencies, so I like this much better.

Thanks.
Jeff Garzik - June 2, 2010, 5:50 p.m.
On 05/29/2010 06:47 AM, Stefan Richter wrote:
> Signed-off-by: Stefan Richter<stefanr@s5r6.in-berlin.de>
> ---
>   drivers/ata/Kconfig |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 73f8833..aa85a98 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -168,10 +168,10 @@ config ATA_BMDMA
>   	default y
>   	help
>   	  This option adds support for SFF ATA controllers with BMDMA
> -	  capability.  BMDMA stands for bus-master DMA and the
> -	  de-facto DMA interface for SFF controllers.
> +	  capability.  BMDMA stands for bus-master DMA and is the
> +	  de facto DMA interface for SFF controllers.
>
> -	  If unuser, say Y.
> +	  If unsure, say Y.
>
>   if ATA_BMDMA

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 73f8833..aa85a98 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -168,10 +168,10 @@  config ATA_BMDMA
 	default y
 	help
 	  This option adds support for SFF ATA controllers with BMDMA
-	  capability.  BMDMA stands for bus-master DMA and the
-	  de-facto DMA interface for SFF controllers.
+	  capability.  BMDMA stands for bus-master DMA and is the
+	  de facto DMA interface for SFF controllers.
 
-	  If unuser, say Y.
+	  If unsure, say Y.
 
 if ATA_BMDMA