diff mbox

[ovs-dev] INSTALL.SSL.md: Fix arguments to "ovs-pki req" command.

Message ID 1446584930-28831-1-git-send-email-blp@nicira.com
State Accepted
Headers show

Commit Message

Ben Pfaff Nov. 3, 2015, 9:08 p.m. UTC
Reported-by: Aaron Rosen <aaronorosen@gmail.com>
Reported-at: http://openvswitch.org/pipermail/dev/2015-November/061778.html
Signed-off-by: Ben Pfaff <blp@nicira.com>
---
 INSTALL.SSL.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Nov. 25, 2015, 8:40 a.m. UTC | #1
On Tue, Nov 03, 2015 at 01:08:50PM -0800, Ben Pfaff wrote:
> Reported-by: Aaron Rosen <aaronorosen@gmail.com>
> Reported-at: http://openvswitch.org/pipermail/dev/2015-November/061778.html
> Signed-off-by: Ben Pfaff <blp@nicira.com>

Reviewed-by: Simon Horman <simon.horman@netronome.com>
Flavio Leitner Nov. 26, 2015, 10:37 p.m. UTC | #2
On Tue, Nov 03, 2015 at 01:08:50PM -0800, Ben Pfaff wrote:
> Reported-by: Aaron Rosen <aaronorosen@gmail.com>
> Reported-at: http://openvswitch.org/pipermail/dev/2015-November/061778.html
> Signed-off-by: Ben Pfaff <blp@nicira.com>
> ---

$ sudo ovs-pki req sc switch 
/bin/ovs-pki: req must have exactly one argument; use --help for help

$ ovs-pki req --help 
...
  req NAME             Create new private key and certificate request
                       named NAME-privkey.pem and NAME-req.pem, resp.

It seems to have been a copy&paste error from:
   % ovs-pki req+sign sc switch

Acked-by: Flavio Leitner <fbl@sysclose.org>
Ben Pfaff Nov. 29, 2015, 7:23 p.m. UTC | #3
On Thu, Nov 26, 2015 at 08:37:30PM -0200, Flavio Leitner wrote:
> On Tue, Nov 03, 2015 at 01:08:50PM -0800, Ben Pfaff wrote:
> > Reported-by: Aaron Rosen <aaronorosen@gmail.com>
> > Reported-at: http://openvswitch.org/pipermail/dev/2015-November/061778.html
> > Signed-off-by: Ben Pfaff <blp@nicira.com>
> > ---
> 
> $ sudo ovs-pki req sc switch 
> /bin/ovs-pki: req must have exactly one argument; use --help for help
> 
> $ ovs-pki req --help 
> ...
>   req NAME             Create new private key and certificate request
>                        named NAME-privkey.pem and NAME-req.pem, resp.
> 
> It seems to have been a copy&paste error from:
>    % ovs-pki req+sign sc switch
> 
> Acked-by: Flavio Leitner <fbl@sysclose.org>

Thanks Simon, Flavio, Aaron.  I applied this to master, branch-2.4, and
branch-2.3.
diff mbox

Patch

diff --git a/INSTALL.SSL.md b/INSTALL.SSL.md
index 06be303..714c6ec 100644
--- a/INSTALL.SSL.md
+++ b/INSTALL.SSL.md
@@ -202,7 +202,7 @@  more secure.
 
 1. Run the following command on the Open vSwitch itself:
 
-       % ovs-pki req sc switch
+       % ovs-pki req sc
 
    (This command does not require a copy of any of the PKI files
    generated by "ovs-pki init", and you should not copy them to the