| Message ID | 20151103210313.GA25989@waldemar-brodkorb.de |
|---|---|
| State | Accepted |
| Headers | show |
Dear Waldemar Brodkorb, On Tue, 3 Nov 2015 22:03:14 +0100, Waldemar Brodkorb wrote: > +ifeq ($(BR2_sparc64),y) > +BOOST_OPTS += architecture=sparc instruction-set=ultrasparc > +endif We're not setting architecture= nor instruction-set= for any other architecture. Should we do so ? Should the instruction-set be set to BR2_GCC_TARGET_TUNE ? Thomas
Hi, Thomas Petazzoni wrote, > Dear Waldemar Brodkorb, > > On Tue, 3 Nov 2015 22:03:14 +0100, Waldemar Brodkorb wrote: > > > +ifeq ($(BR2_sparc64),y) > > +BOOST_OPTS += architecture=sparc instruction-set=ultrasparc > > +endif > > We're not setting architecture= nor instruction-set= for any other > architecture. Should we do so ? > > Should the instruction-set be set to BR2_GCC_TARGET_TUNE ? You mean BR2_GCC_TARGET_CPU? No, because leon3 is not set in boost. To do minimal damage to other architectures, I would just set it for sparc/sparc64. The boost architecture does not always match the buildroot architecture name. (f.e. ppc is power) I think 0003-Remove-bogus-c3-cpu-varant-for-SPARC.patch could be removed, when a correct setting is used for sparc32. best regards Waldemar
Dear Waldemar Brodkorb, On Tue, 3 Nov 2015 22:03:14 +0100, Waldemar Brodkorb wrote: > The default for sparc is v7, which doesn't work for sparc64. > Use ultrasparc for sparc64. > Fixes following autobuild errors: > http://autobuild.buildroot.net/results/0cad0a6eddc153098bb6d1501afd1cf4a57a82d1/ > > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> > --- > package/boost/boost.mk | 4 ++++ > 1 file changed, 4 insertions(+) Applied, thanks. Thomas
diff --git a/package/boost/boost.mk b/package/boost/boost.mk index 80325b0..d91baf1 100644 --- a/package/boost/boost.mk +++ b/package/boost/boost.mk @@ -89,6 +89,10 @@ BOOST_OPTS += toolset=gcc \ abi=$(BOOST_ABI) \ variant=$(if $(BR2_ENABLE_DEBUG),debug,release) +ifeq ($(BR2_sparc64),y) +BOOST_OPTS += architecture=sparc instruction-set=ultrasparc +endif + # By default, Boost build and installs both the shared and static # variants. Override that if we want static only or shared only. ifeq ($(BR2_STATIC_LIBS),y)
The default for sparc is v7, which doesn't work for sparc64. Use ultrasparc for sparc64. Fixes following autobuild errors: http://autobuild.buildroot.net/results/0cad0a6eddc153098bb6d1501afd1cf4a57a82d1/ Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> --- package/boost/boost.mk | 4 ++++ 1 file changed, 4 insertions(+)