Patchwork qemu-io: Fix error messages

login
register
mail settings
Submitter Kevin Wolf
Date May 28, 2010, 6:15 p.m.
Message ID <1275070504-8690-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/53954/
State New
Headers show

Comments

Kevin Wolf - May 28, 2010, 6:15 p.m.
The truncate and getlength commands passed a negative error number to strerror.
They also happen to be the two functions that are lacking a newline at the end
of their error message.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Christoph Hellwig - May 29, 2010, 9:16 a.m.
On Fri, May 28, 2010 at 08:15:04PM +0200, Kevin Wolf wrote:
> The truncate and getlength commands passed a negative error number to strerror.
> They also happen to be the two functions that are lacking a newline at the end
> of their error message.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Ok,


Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch

diff --git a/qemu-io.c b/qemu-io.c
index 72a4524..7c6120b 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1317,7 +1317,7 @@  truncate_f(int argc, char **argv)
 
 	ret = bdrv_truncate(bs, offset);
 	if (ret < 0) {
-		printf("truncate: %s", strerror(ret));
+		printf("truncate: %s\n", strerror(-ret));
 		return 0;
 	}
 
@@ -1342,7 +1342,7 @@  length_f(int argc, char **argv)
 
 	size = bdrv_getlength(bs);
 	if (size < 0) {
-		printf("getlength: %s", strerror(size));
+		printf("getlength: %s\n", strerror(-size));
 		return 0;
 	}