Patchwork sctp: rfc conformance fixes

login
register
mail settings
Submitter David Miller
Date Oct. 22, 2008, 11:46 p.m.
Message ID <20081022.164636.143240158.davem@davemloft.net>
Download mbox | patch
Permalink /patch/5395/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

David Miller - Oct. 22, 2008, 11:46 p.m.
From: Jeremy Kerr <jk@ozlabs.org>
Date: Thu, 23 Oct 2008 09:54:02 +1100

> > Oddly enough, none of this series made it to patchwork.
> 
> I'll chase this up then - could you formward a copy of one of the 
> messages after it has come through the list?

Here is one of them.
Return-Path: <vladislav.yasevich@hp.com>
X-Original-To: davem@davemloft.net
Delivered-To: davem@davemloft.net
Received: from g5t0008.atlanta.hp.com (g5t0008.atlanta.hp.com [15.192.0.45])
	by sunset.davemloft.net (Postfix) with ESMTP id B6A09C8C192
	for <davem@davemloft.net>; Tue, 21 Oct 2008 19:08:29 -0700 (PDT)
Received: from smtp2.fc.hp.com (smtp.cnd.hp.com [15.11.136.114])
	by g5t0008.atlanta.hp.com (Postfix) with ESMTP id 7C98524554;
	Wed, 22 Oct 2008 02:08:50 +0000 (UTC)
Received: from localhost.localdomain (squirrel.fc.hp.com [15.11.146.57])
	by smtp2.fc.hp.com (Postfix) with ESMTP id 3B1CC2892FA;
	Wed, 22 Oct 2008 01:55:45 +0000 (UTC)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	Wei Yongjun <yjwei@cn.fujitsu.com>,
	Vlad Yasevich <vladislav.yasevich@hp.com>
Subject: [PATCH 1/4] sctp: Drop ICMP packet too big message with MTU larger than current PMTU
Date: Tue, 21 Oct 2008 22:08:44 -0400
Message-Id: <1224641327-11913-2-git-send-email-vladislav.yasevich@hp.com>
X-Mailer: git-send-email 1.5.3.5
In-Reply-To: <1224641327-11913-1-git-send-email-vladislav.yasevich@hp.com>
References: <1224641327-11913-1-git-send-email-vladislav.yasevich@hp.com>

From: Wei Yongjun <yjwei@cn.fujitsu.com>

If ICMP packet too big message is received with MTU larger than current
PMTU, SCTP will still accept this ICMP message and sync the PMTU of assoc
with the wrong MTU.

Endpoing A                 Endpoint B
(ESTABLISHED)              (ESTABLISHED)
ICMP         --------->
(packet too big, MTU too larger)
                           sync PMTU

This patch fixed the problem by drop that ICMP message.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
 net/sctp/input.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Oct. 22, 2008, 11:48 p.m.
From: David Miller <davem@davemloft.net>
Date: Wed, 22 Oct 2008 16:46:36 -0700 (PDT)

> From: Jeremy Kerr <jk@ozlabs.org>
> Date: Thu, 23 Oct 2008 09:54:02 +1100
> 
> > > Oddly enough, none of this series made it to patchwork.
> > 
> > I'll chase this up then - could you formward a copy of one of the 
> > messages after it has come through the list?
> 
> Here is one of them.

Sorry, I'm a bozo, that was a copy that made it privately to me.

I don't have any copies in my inbox that came via vger.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vlad Yasevich - Oct. 23, 2008, 1:24 a.m.
David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 22 Oct 2008 16:46:36 -0700 (PDT)
> 
>> From: Jeremy Kerr <jk@ozlabs.org>
>> Date: Thu, 23 Oct 2008 09:54:02 +1100
>>
>>>> Oddly enough, none of this series made it to patchwork.
>>> I'll chase this up then - could you formward a copy of one of the 
>>> messages after it has come through the list?
>> Here is one of them.
> 
> Sorry, I'm a bozo, that was a copy that made it privately to me.
> 
> I don't have any copies in my inbox that came via vger.
> 

Really?  They made it to vger and back out.  They are also in
the archive or marc.   I wonder which black hole some of them
disappeared to... :)

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 23, 2008, 4:06 a.m.
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 22 Oct 2008 21:24:47 -0400

> David Miller wrote:
> > From: David Miller <davem@davemloft.net>
> > Date: Wed, 22 Oct 2008 16:46:36 -0700 (PDT)
> > 
> >> From: Jeremy Kerr <jk@ozlabs.org>
> >> Date: Thu, 23 Oct 2008 09:54:02 +1100
> >>
> >>>> Oddly enough, none of this series made it to patchwork.
> >>> I'll chase this up then - could you formward a copy of one of the 
> >>> messages after it has come through the list?
> >> Here is one of them.
> > 
> > Sorry, I'm a bozo, that was a copy that made it privately to me.
> > 
> > I don't have any copies in my inbox that came via vger.
> > 
> 
> Really?  They made it to vger and back out.  They are also in
> the archive or marc.   I wonder which black hole some of them
> disappeared to... :)

I meant that I didn't save any such copies.

When I read my email I always get 2, 3, 4 copies of every damn
patch, so I delete all but one of those and I happened to save only
the instances that were directly sent to me this time.  It's just
random what happens.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman - Oct. 23, 2008, 6:15 a.m.
On Wed, Oct 22, 2008 at 09:06:49PM -0700, David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> Date: Wed, 22 Oct 2008 21:24:47 -0400
> 
> > David Miller wrote:
> > > From: David Miller <davem@davemloft.net>
> > > Date: Wed, 22 Oct 2008 16:46:36 -0700 (PDT)
> > > 
> > >> From: Jeremy Kerr <jk@ozlabs.org>
> > >> Date: Thu, 23 Oct 2008 09:54:02 +1100
> > >>
> > >>>> Oddly enough, none of this series made it to patchwork.
> > >>> I'll chase this up then - could you formward a copy of one of the 
> > >>> messages after it has come through the list?
> > >> Here is one of them.
> > > 
> > > Sorry, I'm a bozo, that was a copy that made it privately to me.
> > > 
> > > I don't have any copies in my inbox that came via vger.
> > > 
> > 
> > Really?  They made it to vger and back out.  They are also in
> > the archive or marc.   I wonder which black hole some of them
> > disappeared to... :)
> 
> I meant that I didn't save any such copies.
> 
> When I read my email I always get 2, 3, 4 copies of every damn
> patch, so I delete all but one of those and I happened to save only
> the instances that were directly sent to me this time.  It's just
> random what happens.

For what it is worth, I use the following procmail rule to elimintate
duplicate messages based on Message-Id.

	PROCMAIL_ROOT=${HOME}/.procmail

        :0
	* ? /usr/bin/formail -D 819200 ${PROCMAIL_ROOT}/log/message.cache
	/dev/null
David Miller - Oct. 23, 2008, 8:06 a.m.
From: Simon Horman <horms@verge.net.au>
Date: Thu, 23 Oct 2008 17:15:16 +1100

> For what it is worth, I use the following procmail rule to elimintate
> duplicate messages based on Message-Id.

Thanks Simon, I'll check it out.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sctp/input.c b/net/sctp/input.c
index a49fa80..bf612d9 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -369,7 +369,7 @@  static void sctp_add_backlog(struct sock *sk, struct sk_buff *skb)
 void sctp_icmp_frag_needed(struct sock *sk, struct sctp_association *asoc,
 			   struct sctp_transport *t, __u32 pmtu)
 {
-	if (!t || (t->pathmtu == pmtu))
+	if (!t || (t->pathmtu <= pmtu))
 		return;
 
 	if (sock_owned_by_user(sk)) {