| Message ID | 1446563847-14005-44-git-send-email-agruenba@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
> On Nov 3, 2015, at 8:17 AM, Andreas Gruenbacher <agruenba@redhat.com> wrote: > > Don't allow acls which contain unmapped identifiers: they are meaningful > for remote file systems only. Looks fine. Reviewed-by: Andreas Dilger <adilger@dilger.ca> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> > --- > fs/ext4/richacl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c > index 906d048..2115385 100644 > --- a/fs/ext4/richacl.c > +++ b/fs/ext4/richacl.c > @@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl *acl) > int retval, size; > void *value; > > + /* Don't allow acls with unmapped identifiers. */ > + if (richacl_has_unmapped_identifiers(acl)) > + return -EINVAL; > + > if (richacl_equiv_mode(acl, &mode) == 0) { > inode->i_ctime = ext4_current_time(inode); > inode->i_mode = mode; > -- > 2.5.0 > Cheers, Andreas
diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c index 906d048..2115385 100644 --- a/fs/ext4/richacl.c +++ b/fs/ext4/richacl.c @@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl *acl) int retval, size; void *value; + /* Don't allow acls with unmapped identifiers. */ + if (richacl_has_unmapped_identifiers(acl)) + return -EINVAL; + if (richacl_equiv_mode(acl, &mode) == 0) { inode->i_ctime = ext4_current_time(inode); inode->i_mode = mode;
Don't allow acls which contain unmapped identifiers: they are meaningful for remote file systems only. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> --- fs/ext4/richacl.c | 4 ++++ 1 file changed, 4 insertions(+)