diff mbox

[COLO-Frame,v10,34/38] filter-buffer: Accept zero interval

Message ID 1446551816-15768-35-git-send-email-zhang.zhanghailiang@huawei.com
State New
Headers show

Commit Message

Zhanghailiang Nov. 3, 2015, 11:56 a.m. UTC
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: Jason Wang <jasowang@redhat.com>
---
v10: new patch
---
 net/filter-buffer.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Yang Hongyang Nov. 3, 2015, 12:43 p.m. UTC | #1
Some commit message would be better.

On 2015年11月03日 19:56, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Cc: Jason Wang <jasowang@redhat.com>

Reviewed-by: Yang Hongyang <hongyang.yang@easystack.cn>

> ---
> v10: new patch
> ---
>   net/filter-buffer.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/net/filter-buffer.c b/net/filter-buffer.c
> index 5f0ea70..05313de 100644
> --- a/net/filter-buffer.c
> +++ b/net/filter-buffer.c
> @@ -104,16 +104,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp)
>   {
>       FilterBufferState *s = FILTER_BUFFER(nf);
>
> -    /*
> -     * We may want to accept zero interval when VM FT solutions like MC
> -     * or COLO use this filter to release packets on demand.
> -     */
> -    if (!s->interval) {
> -        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
> -                   "a non-zero interval");
> -        return;
> -    }
> -
>       s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
>       if (s->interval) {
>           timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,
>
Jason Wang Nov. 4, 2015, 2:52 a.m. UTC | #2
On 11/03/2015 08:43 PM, Yang Hongyang wrote:
> Some commit message would be better.

+1

>
> On 2015年11月03日 19:56, zhanghailiang wrote:
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>
> Reviewed-by: Yang Hongyang <hongyang.yang@easystack.cn>
>
>> ---
>> v10: new patch
>> ---
>>   net/filter-buffer.c | 10 ----------
>>   1 file changed, 10 deletions(-)
>>
>> diff --git a/net/filter-buffer.c b/net/filter-buffer.c
>> index 5f0ea70..05313de 100644
>> --- a/net/filter-buffer.c
>> +++ b/net/filter-buffer.c
>> @@ -104,16 +104,6 @@ static void filter_buffer_setup(NetFilterState
>> *nf, Error **errp)
>>   {
>>       FilterBufferState *s = FILTER_BUFFER(nf);
>>
>> -    /*
>> -     * We may want to accept zero interval when VM FT solutions like MC
>> -     * or COLO use this filter to release packets on demand.
>> -     */
>> -    if (!s->interval) {
>> -        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
>> -                   "a non-zero interval");
>> -        return;
>> -    }
>> -
>>       s->incoming_queue =
>> qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
>>       if (s->interval) {
>>           timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,
>>
>
diff mbox

Patch

diff --git a/net/filter-buffer.c b/net/filter-buffer.c
index 5f0ea70..05313de 100644
--- a/net/filter-buffer.c
+++ b/net/filter-buffer.c
@@ -104,16 +104,6 @@  static void filter_buffer_setup(NetFilterState *nf, Error **errp)
 {
     FilterBufferState *s = FILTER_BUFFER(nf);
 
-    /*
-     * We may want to accept zero interval when VM FT solutions like MC
-     * or COLO use this filter to release packets on demand.
-     */
-    if (!s->interval) {
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
-                   "a non-zero interval");
-        return;
-    }
-
     s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
     if (s->interval) {
         timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,