| Message ID | 56384001.1070807@samsung.com |
|---|---|
| State | Rejected |
| Delegated to: | Tom Rini |
| Headers | show |
On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: > Dear Tom, > > The following changes since commit 0e067a65f57189703668826d9841fea477026bf6: > > x86: Select the ns16550 debug UART for minnowmax, chromebook_link (2015-10-30 18:04:14 -0400) > > are available in the git repository at: > > http://git.denx.de/u-boot-samsung > > for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc: > > samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) > NAK: +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: sandbox-adc.h: No such file or directory +(sandbox) #include <sandbox-adc.h> +(sandbox) ^ +(sandbox) compilation terminated. +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1 +(sandbox) make[2]: *** [drivers/adc] Error 2 +(sandbox) make[1]: *** [drivers] Error 2 "sandbox: add ADC unit tests" is missing adding sandbox-adc.h
Dear Przemyslaw Marczak, 2015년 11월 4일 수요일, Tom Rini<trini@konsulko.com>님이 작성한 메시지: > On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: > > > Dear Tom, > > > > The following changes since commit > 0e067a65f57189703668826d9841fea477026bf6: > > > > x86: Select the ns16550 debug UART for minnowmax, chromebook_link > (2015-10-30 18:04:14 -0400) > > > > are available in the git repository at: > > > > http://git.denx.de/u-boot-samsung > > > > for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc: > > > > samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) > > > > NAK: > > +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: sandbox-adc.h: No > such file or directory > +(sandbox) #include <sandbox-adc.h> > +(sandbox) ^ > +(sandbox) compilation terminated. > +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1 > +(sandbox) make[2]: *** [drivers/adc] Error 2 > +(sandbox) make[1]: *** [drivers] Error 2 > > "sandbox: add ADC unit tests" is missing adding sandbox-adc.h > > Could you please check it? > -- > Tom > Thanks, Minkyu Kang.
Hello Minkyu, On 11/04/2015 03:05 AM, Minkyu Kang wrote: > Dear Przemyslaw Marczak, > > 2015년 11월 4일 수요일, Tom Rini<trini@konsulko.com > > On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: > > > Dear Tom, > > > > The following changes since commit > 0e067a65f57189703668826d9841fea477026bf6: > > > > x86: Select the ns16550 debug UART for minnowmax, > chromebook_link (2015-10-30 18:04:14 -0400) > > > > are available in the git repository at: > > > > http://git.denx.de/u-boot-samsung > > > > for you to fetch changes up to > de5f9733f653091d4b227914d04432099a6448dc: > > > > samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) > > > > NAK: > > +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: > sandbox-adc.h: No such file or directory > +(sandbox) #include <sandbox-adc.h> > +(sandbox) ^ > +(sandbox) compilation terminated. > +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1 > +(sandbox) make[2]: *** [drivers/adc] Error 2 > +(sandbox) make[1]: *** [drivers] Error 2 > > "sandbox: add ADC unit tests" is missing adding sandbox-adc.h > > > Could you please check it? > > -- > Tom > > > Thanks, > Minkyu Kang. > > > -- > Thanks. > Minkyu Kang. Sorry for this mistake. I have this file locally, so it build properly for me. Is that good to you if I send you a patch with this missing file, to squash with one commit? Or do you prefer V3 of the whole patch-set? Best regards,
Dear Przemyslaw Marczak, On 4 November 2015 at 18:37, Przemyslaw Marczak <p.marczak@samsung.com> wrote: > Hello Minkyu, > > On 11/04/2015 03:05 AM, Minkyu Kang wrote: > >> Dear Przemyslaw Marczak, >> >> 2015년 11월 4일 수요일, Tom Rini<trini@konsulko.com >> >> On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: >> >> > Dear Tom, >> > >> > The following changes since commit >> 0e067a65f57189703668826d9841fea477026bf6: >> > >> > x86: Select the ns16550 debug UART for minnowmax, >> chromebook_link (2015-10-30 18:04:14 -0400) >> > >> > are available in the git repository at: >> > >> > http://git.denx.de/u-boot-samsung >> > >> > for you to fetch changes up to >> de5f9733f653091d4b227914d04432099a6448dc: >> > >> > samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) >> > >> >> NAK: >> >> +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: >> sandbox-adc.h: No such file or directory >> +(sandbox) #include <sandbox-adc.h> >> +(sandbox) ^ >> +(sandbox) compilation terminated. >> +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1 >> +(sandbox) make[2]: *** [drivers/adc] Error 2 >> +(sandbox) make[1]: *** [drivers] Error 2 >> >> "sandbox: add ADC unit tests" is missing adding sandbox-adc.h >> >> >> Could you please check it? >> >> -- >> Tom >> >> >> Thanks, >> Minkyu Kang. >> >> >> -- >> Thanks. >> Minkyu Kang. >> > > Sorry for this mistake. I have this file locally, so it build properly for > me. > > Is that good to you if I send you a patch with this missing file, to > squash with one commit? Or do you prefer V3 of the whole patch-set? > If squash your patch then I should do push forced. I think it's not a good way. I will merge your patch separately. Thanks, Minkyu Kang.
Hello Minkyu, On 11/04/2015 04:43 PM, Minkyu Kang wrote: > Dear Przemyslaw Marczak, > > On 4 November 2015 at 18:37, Przemyslaw Marczak <p.marczak@samsung.com > <mailto:p.marczak@samsung.com>> wrote: > > Hello Minkyu, > > On 11/04/2015 03:05 AM, Minkyu Kang wrote: > > Dear Przemyslaw Marczak, > > 2015년 11월 4일 수요일, Tom Rini<trini@konsulko.com > <mailto:trini@konsulko.com> > > On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote: > > > Dear Tom, > > > > The following changes since commit > 0e067a65f57189703668826d9841fea477026bf6: > > > > x86: Select the ns16550 debug UART for minnowmax, > chromebook_link (2015-10-30 18:04:14 -0400) > > > > are available in the git repository at: > > > > http://git.denx.de/u-boot-samsung > > > > for you to fetch changes up to > de5f9733f653091d4b227914d04432099a6448dc: > > > > samsung: clean up checkpatch issues (2015-11-02 > 10:38:22 +0900) > > > > NAK: > > +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: > sandbox-adc.h: No such file or directory > +(sandbox) #include <sandbox-adc.h> > +(sandbox) ^ > +(sandbox) compilation terminated. > +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1 > +(sandbox) make[2]: *** [drivers/adc] Error 2 > +(sandbox) make[1]: *** [drivers] Error 2 > > "sandbox: add ADC unit tests" is missing adding sandbox-adc.h > > > Could you please check it? > > -- > Tom > > > Thanks, > Minkyu Kang. > > > -- > Thanks. > Minkyu Kang. > > > Sorry for this mistake. I have this file locally, so it build > properly for me. > > Is that good to you if I send you a patch with this missing file, to > squash with one commit? Or do you prefer V3 of the whole patch-set? > > > If squash your patch then I should do push forced. > I think it's not a good way. > I will merge your patch separately. > > Thanks, > Minkyu Kang. > -- > from. prom. > www.promsoft.net <http://www.promsoft.net> Squashing would be better if we want prevent build break. This single file (include/sandbox-adc.h) will not conflict with any other, so it's easy to rebase it. This is not a master tree, so I think that push with force will not cause any problems. But if you really prefer to take it as a separate patch, then I will send one, with a proper commit message in a moment. Best regards,
Dear Tom, The following changes since commit 0e067a65f57189703668826d9841fea477026bf6: x86: Select the ns16550 debug UART for minnowmax, chromebook_link (2015-10-30 18:04:14 -0400) are available in the git repository at: http://git.denx.de/u-boot-samsung for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc: samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900) ---------------------------------------------------------------- Minkyu Kang (5): arm: exynos: clean up checkpatch issues smdkv310: clean up checkpatch issues smdk2410: clean up checkpatch issues odroid: clean up checkpatch issues samsung: clean up checkpatch issues Przemyslaw Marczak (16): samsung: board/misc: check returned pointer for get_board_type() calls s5p: cpu_info: print "cpu-model" if exists in dts Peach-Pi: dts: add cpu-model string Exynos5422/5800: set cpu id to 0x5422 dm: pmic: add s2mps11 PMIC I/O driver dm: regulator: add function device_get_supply_regulator() dm: adc: add simple ADC uclass implementation dm: adc: add Exynos54xx compatible ADC driver Odroid-XU3: enable s2mps11 PMIC support Exynos54xx: dts: add ADC node Odroid-XU3: dts: enable ADC, with request for pre-reloc bind exynos5-dt-types: add board detection for Odroid XU3/XU3L/XU4. sandbox: add ADC driver sandbox: add ADC unit tests Exynos4412: pinmux: disable pull for MMC pins s5p sdhci: call pinmux for card's gpio pins before use them arch/arm/cpu/armv7/s5p-common/cpu_info.c | 14 +- arch/arm/dts/exynos5422-odroidxu3.dts | 12 + arch/arm/dts/exynos54xx.dtsi | 7 + arch/arm/dts/exynos5800-peach-pi.dts | 1 + arch/arm/mach-exynos/clock.c | 16 +- arch/arm/mach-exynos/clock_init_exynos5.c | 2 +- arch/arm/mach-exynos/common_setup.h | 4 +- arch/arm/mach-exynos/dmc_init_ddr3.c | 8 +- arch/arm/mach-exynos/include/mach/adc.h | 44 +++ arch/arm/mach-exynos/include/mach/cpu.h | 6 +- arch/arm/mach-exynos/include/mach/gpio.h | 4 +- arch/arm/mach-exynos/pinmux.c | 4 +- arch/arm/mach-exynos/power.c | 2 +- arch/sandbox/dts/sandbox_pmic.dtsi | 2 +- arch/sandbox/dts/test.dts | 6 + board/samsung/common/Makefile | 5 +- board/samsung/common/board.c | 4 +- board/samsung/common/exynos5-dt-types.c | 196 +++++++++++++ board/samsung/common/exynos5-dt.c | 12 + board/samsung/common/misc.c | 10 +- board/samsung/odroid/odroid.c | 15 +- board/samsung/smdk2410/smdk2410.c | 10 +- board/samsung/smdkv310/smdkv310.c | 8 +- configs/odroid-xu3_defconfig | 5 + configs/sandbox_defconfig | 2 + doc/device-tree-bindings/adc/adc.txt | 62 +++++ doc/device-tree-bindings/exynos/soc.txt | 21 ++ doc/device-tree-bindings/pmic/s2mps11.txt | 17 ++ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/adc/Kconfig | 30 ++ drivers/adc/Makefile | 10 + drivers/adc/adc-uclass.c | 409 ++++++++++++++++++++++++++++ drivers/adc/exynos-adc.c | 145 ++++++++++ drivers/adc/sandbox.c | 174 ++++++++++++ drivers/mmc/s5p_sdhci.c | 14 +- drivers/power/pmic/Kconfig | 14 + drivers/power/pmic/Makefile | 1 + drivers/power/pmic/s2mps11.c | 62 +++++ drivers/power/regulator/regulator-uclass.c | 7 + include/adc.h | 288 ++++++++++++++++++++ include/configs/odroid_xu3.h | 12 + include/dm/uclass-id.h | 1 + include/power/regulator.h | 16 ++ include/power/s2mps11.h | 109 ++++++++ include/power/sandbox_pmic.h | 4 + include/samsung/exynos5-dt-types.h | 27 ++ test/dm/Makefile | 1 + test/dm/adc.c | 165 +++++++++++ 49 files changed, 1935 insertions(+), 56 deletions(-) create mode 100644 board/samsung/common/exynos5-dt-types.c create mode 100644 doc/device-tree-bindings/adc/adc.txt create mode 100644 doc/device-tree-bindings/exynos/soc.txt create mode 100644 doc/device-tree-bindings/pmic/s2mps11.txt create mode 100644 drivers/adc/Kconfig create mode 100644 drivers/adc/Makefile create mode 100644 drivers/adc/adc-uclass.c create mode 100644 drivers/adc/exynos-adc.c create mode 100644 drivers/adc/sandbox.c create mode 100644 drivers/power/pmic/s2mps11.c create mode 100644 include/adc.h create mode 100644 include/power/s2mps11.h create mode 100644 include/samsung/exynos5-dt-types.h create mode 100644 test/dm/adc.c