diff mbox

libgo patch committed: Update to Go 1.5 release

Message ID CAOyqgcU-qHPqvbknk1ctWJz0Luko0kthQsydGuXN7Zpkya+taw@mail.gmail.com
State New
Headers show

Commit Message

Ian Lance Taylor Nov. 2, 2015, 7:58 p.m. UTC 
On Mon, Nov 2, 2015 at 1:37 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Ian Lance Taylor <iant@golang.org> writes:
>
>> On Sun, Nov 1, 2015 at 1:39 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> ../../../../libgo/go/syscall/exec_linux.go:185:37: error: reference to undefined name 'TIOCSPGRP'
>>>    _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp))
>>>                                      ^
>>>
>>> $ grep TIOCSPGRP gen-sysinfo.go
>>> // unknowndefine TIOCSPGRP _IOW('t', 118, int)
>>
>> I have committed this patch which may fix the problem.  Let me know if
>> it still happens for you.  Thanks.
>
> ../../../../libgo/go/syscall/exec_linux.go:185:37: error: integer constant overflow
>    _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp))
>
> // unknowndefine TIOCSPGRP _IOW('t', 118, int)
> const _TIOCSPGRP_val = 2147775606

You still didn't say what system you are trying.  It makes any fix hard to test.

Still, I committed this patch in the hopes of fixing this problem.

Ian
diff mbox

Patch

Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 229645)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@ 
-6b4b969f552b8f9ac87a715d5ad06e52bd031b60
+e9550aa81d38ada037f675f50cbc09e6f1c35c12
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/go/syscall/exec_unix.go
===================================================================
--- libgo/go/syscall/exec_unix.go	(revision 229616)
+++ libgo/go/syscall/exec_unix.go	(working copy)
@@ -41,10 +41,10 @@  import (
 //sysnb	raw_close(fd int) (err Errno)
 //close(fd _C_int) _C_int
 
-//sysnb	raw_ioctl(fd int, cmd int, val int) (rval int, err Errno)
+//sysnb	raw_ioctl(fd int, cmd uintptr, val int) (rval int, err Errno)
 //__go_ioctl(fd _C_int, cmd _C_int, val _C_int) _C_int
 
-//sysnb raw_ioctl_ptr(fd int, cmd int, val unsafe.Pointer) (rval int, err Errno)
+//sysnb raw_ioctl_ptr(fd int, cmd uintptr, val unsafe.Pointer) (rval int, err Errno)
 //__go_ioctl_ptr(fd _C_int, cmd _C_int, val unsafe.Pointer) _C_int
 
 //sysnb	raw_execve(argv0 *byte, argv **byte, envv **byte) (err Errno)