[tpmdd-devel,PULL,REQUEST] TPM fixes for v4.3
mbox

Message ID 20151102194829.GA10113@intel.com
State New
Headers show

Pull-request

https://github.com/jsakkine/linux-tpmdd.git tags/tpmdd-v4.3-fixes

Message

Jarkko Sakkinen Nov. 2, 2015, 7:48 p.m. UTC
Hi James,

Couple of critical bug fixes. Both apply on top of v4.4-rc1 but I can
send a separate pull request once it is released if needed (I have also
one additional bug fix only for v4.4-rc1).

/Jarkko

The following changes since commit 6a13feb9c82803e2b815eca72fa7a9f5561d7861:

  Linux 4.3 (2015-11-01 16:05:25 -0800)

are available in the git repository at:

  https://github.com/jsakkine/linux-tpmdd.git tags/tpmdd-v4.3-fixes

for you to fetch changes up to 7140a1b7eb889d269945e9255503484742bced65:

  TPM: revert list behavior in 770ab65 (2015-11-02 19:58:02 +0200)

----------------------------------------------------------------
Fixes for the TPM subsystem in Linux v4.3

----------------------------------------------------------------
Christophe JAILLET (1):
      TPM: Avoid reference to potentially freed memory

Jarkko Sakkinen (1):
      TPM: revert list behavior in 770ab65

 drivers/char/tpm/tpm-chip.c | 2 +-
 drivers/char/tpm/tpm_of.c   | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

------------------------------------------------------------------------------

Comments

Christophe JAILLET Nov. 2, 2015, 10:40 p.m. UTC | #1
Hi,

according to what I've seen concerning tpm_of.c, some of_node_put have 
been added later on, as proposed BUT the initial call (line 56) is still 
there and should be IMHO be removed.

Best regards
CJ

Le 02/11/2015 20:48, Jarkko Sakkinen a écrit :
> Hi James,
>
> Couple of critical bug fixes. Both apply on top of v4.4-rc1 but I can
> send a separate pull request once it is released if needed (I have also
> one additional bug fix only for v4.4-rc1).
>
> /Jarkko
>
> The following changes since commit 6a13feb9c82803e2b815eca72fa7a9f5561d7861:
>
>    Linux 4.3 (2015-11-01 16:05:25 -0800)
>
> are available in the git repository at:
>
>    https://github.com/jsakkine/linux-tpmdd.git tags/tpmdd-v4.3-fixes
>
> for you to fetch changes up to 7140a1b7eb889d269945e9255503484742bced65:
>
>    TPM: revert list behavior in 770ab65 (2015-11-02 19:58:02 +0200)
>
> ----------------------------------------------------------------
> Fixes for the TPM subsystem in Linux v4.3
>
> ----------------------------------------------------------------
> Christophe JAILLET (1):
>        TPM: Avoid reference to potentially freed memory
>
> Jarkko Sakkinen (1):
>        TPM: revert list behavior in 770ab65
>
>   drivers/char/tpm/tpm-chip.c | 2 +-
>   drivers/char/tpm/tpm_of.c   | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
>


------------------------------------------------------------------------------
Jarkko Sakkinen Nov. 3, 2015, 5:43 a.m. UTC | #2
On Mon, Nov 02, 2015 at 11:40:00PM +0100, Marion & Christophe JAILLET wrote:
> Hi,
> 
> according to what I've seen concerning tpm_of.c, some of_node_put have been
> added later on, as proposed BUT the initial call (line 56) is still there
> and should be IMHO be removed.

It wasn't my intention.

Somehow the first line removal cut out (the original patch did not apply
cleanly). I have to create another tag and pull request. In future,
instead of linux-next the better choice to base your fixes is latest
mainline in order to git am not complain about wrong sha1's.

Peter, should I we proceed with this or do you want to do the pull
request?

> Best regards
> CJ

/Jarkko

> Le 02/11/2015 20:48, Jarkko Sakkinen a écrit :
> >Hi James,
> >
> >Couple of critical bug fixes. Both apply on top of v4.4-rc1 but I can
> >send a separate pull request once it is released if needed (I have also
> >one additional bug fix only for v4.4-rc1).
> >
> >/Jarkko
> >
> >The following changes since commit 6a13feb9c82803e2b815eca72fa7a9f5561d7861:
> >
> >   Linux 4.3 (2015-11-01 16:05:25 -0800)
> >
> >are available in the git repository at:
> >
> >   https://github.com/jsakkine/linux-tpmdd.git tags/tpmdd-v4.3-fixes
> >
> >for you to fetch changes up to 7140a1b7eb889d269945e9255503484742bced65:
> >
> >   TPM: revert list behavior in 770ab65 (2015-11-02 19:58:02 +0200)
> >
> >----------------------------------------------------------------
> >Fixes for the TPM subsystem in Linux v4.3
> >
> >----------------------------------------------------------------
> >Christophe JAILLET (1):
> >       TPM: Avoid reference to potentially freed memory
> >
> >Jarkko Sakkinen (1):
> >       TPM: revert list behavior in 770ab65
> >
> >  drivers/char/tpm/tpm-chip.c | 2 +-
> >  drivers/char/tpm/tpm_of.c   | 2 ++
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> 

------------------------------------------------------------------------------