From patchwork Fri May 28 15:03:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: usb-serial: Fail instead of crash when chardev is missing From: Markus Armbruster X-Patchwork-Id: 53907 Message-Id: To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Date: Fri, 28 May 2010 17:03:22 +0200 Signed-off-by: Markus Armbruster Acked-by: Gerd Hoffmann --- hw/usb-serial.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-serial.c b/hw/usb-serial.c index 5b2483a..c19580f 100644 --- a/hw/usb-serial.c +++ b/hw/usb-serial.c @@ -545,6 +545,11 @@ static int usb_serial_initfn(USBDevice *dev) USBSerialState *s = DO_UPCAST(USBSerialState, dev, dev); s->dev.speed = USB_SPEED_FULL; + if (!s->cs) { + error_report("Property chardev is required"); + return -1; + } + qemu_chr_add_handlers(s->cs, usb_serial_can_read, usb_serial_read, usb_serial_event, s); usb_serial_handle_reset(dev);