From patchwork Mon Nov 2 12:06:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Brown X-Patchwork-Id: 538990 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8DD2914018C for ; Mon, 2 Nov 2015 23:06:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=OTw18VzI; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; q=dns; s=default; b=tGH49KWDZ6R2t9G9 +8IuwoQSu/euxlzO6r+yABMXJ4rUPGWuYZo/42KscrWN3PKOqWDDiOjIDBv0fXcv YnR2cJHIGMGPV8uIQSDk656SPcHa7xxM/G7gY+tZuYBR4+6Sq8A6F637520vvwaP Rn81p7DAtpi0wAYiJHT1L5PgH6I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; s=default; bh=A3uKu+PBsmLThPh/KGcyT9 PSCsI=; b=OTw18VzIuxjdUCPhgPLGhDRexaoylJdOlzQFjFXitMFIgIrazm5pSR xjjP+LvZpB01elrkTD/wHuzBnGjaS2LLUk7fh3q21bInPd/e7vchIgvWiB09WaOQ qXWg0qNsHSaIxGSWb5zmW7EfIqORUG74E0uU6GtHzYR/YplmBOsVw= Received: (qmail 26427 invoked by alias); 2 Nov 2015 12:06:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26410 invoked by uid 89); 2 Nov 2015 12:06:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 12:06:22 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZtDsQ-0004yF-K7 from Julian_Brown@mentor.com ; Mon, 02 Nov 2015 04:06:18 -0800 Received: from octopus (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 2 Nov 2015 12:06:17 +0000 Date: Mon, 2 Nov 2015 12:06:11 +0000 From: Julian Brown To: Jim Wilson CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] [ARM] neon-testgen.ml typo Message-ID: <20151102120611.167de789@octopus> In-Reply-To: References: MIME-Version: 1.0 X-IsSubscribed: yes Hi, On Thu, 29 Oct 2015 10:23:58 -0700 Jim Wilson wrote: > I noticed a comment typo in this file while using grep to look for > other stuff. The typo is easy to fix. > > I tried running neon-testgen.ml to verify, but it is apparently no > longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have > on Ubuntu 14.04. I get a syntax error. Someone who knows ocaml will > have to fix this. Meanwhile, the patch to fix the typo should still > be OK, as this is a separate problem. This seems to work for me (semicolons in OCaml are separators not terminators - I'm not sure why this worked before). OK to apply? Julian ChangeLog gcc/ * config/arm/neon-testgen.ml (emit_epilogue): Remove extraneous brackets and semicolon. Index: gcc/config/arm/neon-testgen.ml =================================================================== --- gcc/config/arm/neon-testgen.ml (revision 229410) +++ gcc/config/arm/neon-testgen.ml (working copy) @@ -130,14 +130,14 @@ let emit_call chan const_valuator c_type let emit_epilogue chan features regexps = let no_op = List.exists (fun feature -> feature = No_op) features in Printf.fprintf chan "}\n\n"; - (if not no_op then - List.iter (fun regexp -> - Printf.fprintf chan - "/* { dg-final { scan-assembler \"%s\" } } */\n" regexp) + if not no_op then + List.iter (fun regexp -> + Printf.fprintf chan + "/* { dg-final { scan-assembler \"%s\" } } */\n" regexp) regexps - else - () - ); + else + () + (* Check a list of C types to determine which ones are pointers and which ones are const. *)