| Message ID | CAKOQZ8xVuv1kCmg8d_xMs_iQLYfnmUfYWXtjfb_3+kUG2jQdLQ@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
Ian Lance Taylor <iant@golang.org> writes: > On Sun, Nov 1, 2015 at 1:39 AM, Andreas Schwab <schwab@linux-m68k.org> wrote: >> ../../../../libgo/go/syscall/exec_linux.go:185:37: error: reference to undefined name 'TIOCSPGRP' >> _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp)) >> ^ >> >> $ grep TIOCSPGRP gen-sysinfo.go >> // unknowndefine TIOCSPGRP _IOW('t', 118, int) > > I have committed this patch which may fix the problem. Let me know if > it still happens for you. Thanks. ../../../../libgo/go/syscall/exec_linux.go:185:37: error: integer constant overflow _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp)) // unknowndefine TIOCSPGRP _IOW('t', 118, int) const _TIOCSPGRP_val = 2147775606 Andreas.
I see this error when building gccgo from trunk on ppc64le and running
the libgo tests:
exec_unix_test.go:174:43: error: reference to undefined identifier
'syscall.TIOCGPGRP'
errno := syscall.Ioctl(tty.Fd(), syscall.TIOCGPGRP,
uintptr(unsafe.Pointer(&fpgrp)))
^
FAIL: syscall
make[3]: *** [syscall/check] Error 1
On 11/02/2015 03:37 AM, Andreas Schwab wrote:
> Ian Lance Taylor <iant@golang.org> writes:
>
>> On Sun, Nov 1, 2015 at 1:39 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> ../../../../libgo/go/syscall/exec_linux.go:185:37: error: reference to undefined name 'TIOCSPGRP'
>>> _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp))
>>> ^
>>>
>>> $ grep TIOCSPGRP gen-sysinfo.go
>>> // unknowndefine TIOCSPGRP _IOW('t', 118, int)
>> I have committed this patch which may fix the problem. Let me know if
>> it still happens for you. Thanks.
> ../../../../libgo/go/syscall/exec_linux.go:185:37: error: integer constant overflow
> _, err1 = raw_ioctl_ptr(sys.Ctty, TIOCSPGRP, unsafe.Pointer(&pgrp))
>
> // unknowndefine TIOCSPGRP _IOW('t', 118, int)
> const _TIOCSPGRP_val = 2147775606
>
> Andreas.
>
Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 229642) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -65ff1d5fb581717229e5c02796d719671a1e8628 +6b4b969f552b8f9ac87a715d5ad06e52bd031b60 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: libgo/mksysinfo.sh =================================================================== --- libgo/mksysinfo.sh (revision 229616) +++ libgo/mksysinfo.sh (working copy) @@ -183,6 +183,9 @@ enum { #ifdef TIOCSCTTY TIOCSCTTY_val = TIOCSCTTY, #endif +#ifdef TIOCSPGRP + TIOCSPGRP_val = TIOCSPGRP, +#endif #ifdef TIOCGPTN TIOCGPTN_val = TIOCGPTN, #endif @@ -917,6 +920,11 @@ if ! grep '^const TIOCSCTTY' ${OUT} >/de echo 'const TIOCSCTTY = _TIOCSCTTY_val' >> ${OUT} fi fi +if ! grep '^const TIOCSPGRP' ${OUT} >/dev/null 2>&1; then + if grep '^const _TIOCSPGRP_val' ${OUT} >/dev/null 2>&1; then + echo 'const TIOCSPGRP = _TIOCSPGRP_val' >> ${OUT} + fi +fi if ! grep '^const TIOCGPTN' ${OUT} >/dev/null 2>&1; then if grep '^const _TIOCGPTN_val' ${OUT} >/dev/null 2>&1; then echo 'const TIOCGPTN = _TIOCGPTN_val' >> ${OUT}