Patchwork cifs: don't ignore cifs_posix_open_inode_helper return value

login
register
mail settings
Submitter Suresh Jayaraman
Date May 28, 2010, 10:48 a.m.
Message ID <1275043699-21832-1-git-send-email-sjayaraman@suse.de>
Download mbox | patch
Permalink /patch/53880/
State New
Headers show

Comments

Suresh Jayaraman - May 28, 2010, 10:48 a.m.
.and ensure that we propagate the error back to avoid any surprises.

Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
---
 fs/cifs/file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index a83541e..ae89625 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -309,8 +309,8 @@  int cifs_open(struct inode *inode, struct file *file)
 			   on read only files needed here */
 
 			pCifsFile = cifs_fill_filedata(file);
-			cifs_posix_open_inode_helper(inode, file, pCifsInode,
-						     oplock, netfid);
+			rc = cifs_posix_open_inode_helper(inode, file,
+					pCifsInode, oplock, netfid);
 			goto out;
 		} else if ((rc == -EINVAL) || (rc == -EOPNOTSUPP)) {
 			if (tcon->ses->serverNOS)