| Message ID | 1446395775-29443-2-git-send-email-daniel.schwierzeck@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
On Sun, Nov 01, 2015 at 05:36:13PM +0100, Daniel Schwierzeck wrote: > The variables bd_t:bi_memstart and bd_t:bi_memsize have to be > initialized also on MIPS. Otherwise LMB and cmd_bdinfo do not > correctly work. This currently breaks the booting of FIT images > on MIPS. Enable the board_init_f hook setup_board_part1() > for MIPS to fix this. > > Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > Reviewed-by: Tom Rini <trini@konsulko.com>
On 2 November 2015 at 16:37, Tom Rini <trini@konsulko.com> wrote: > On Sun, Nov 01, 2015 at 05:36:13PM +0100, Daniel Schwierzeck wrote: > >> The variables bd_t:bi_memstart and bd_t:bi_memsize have to be >> initialized also on MIPS. Otherwise LMB and cmd_bdinfo do not >> correctly work. This currently breaks the booting of FIT images >> on MIPS. Enable the board_init_f hook setup_board_part1() >> for MIPS to fix this. >> >> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> >> > > Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/common/board_f.c b/common/board_f.c index 7632041..a12ac28 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -551,7 +551,7 @@ static int display_new_sp(void) return 0; } -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_MIPS) static int setup_board_part1(void) { bd_t *bd = gd->bd; @@ -580,7 +580,9 @@ static int setup_board_part1(void) return 0; } +#endif +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) static int setup_board_part2(void) { bd_t *bd = gd->bd; @@ -933,8 +935,10 @@ static init_fnc_t init_sequence_f[] = { reserve_stacks, setup_dram_config, show_dram_config, -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_MIPS) setup_board_part1, +#endif +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) INIT_FUNC_WATCHDOG_RESET setup_board_part2, #endif
The variables bd_t:bi_memstart and bd_t:bi_memsize have to be initialized also on MIPS. Otherwise LMB and cmd_bdinfo do not correctly work. This currently breaks the booting of FIT images on MIPS. Enable the board_init_f hook setup_board_part1() for MIPS to fix this. Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> --- common/board_f.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)