From patchwork Wed Oct 22 21:19:48 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gospodarek X-Patchwork-Id: 5386 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 66D17DDEE4 for ; Thu, 23 Oct 2008 08:26:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbYJVV0R (ORCPT ); Wed, 22 Oct 2008 17:26:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752296AbYJVV0R (ORCPT ); Wed, 22 Oct 2008 17:26:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40794 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbYJVV0Q (ORCPT ); Wed, 22 Oct 2008 17:26:16 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9MLJnt7002661; Wed, 22 Oct 2008 17:19:49 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9MLJmEA001092; Wed, 22 Oct 2008 17:19:49 -0400 Received: from gospo.usersys.redhat.com (gospo.rdu.redhat.com [10.11.228.52]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with SMTP id m9MLJmNk024783; Wed, 22 Oct 2008 17:19:48 -0400 Received: by gospo.usersys.redhat.com (sSMTP sendmail emulation); Wed, 22 Oct 2008 17:19:48 -0400 Date: Wed, 22 Oct 2008 17:19:48 -0400 From: Andy Gospodarek To: Jay Vosburgh Cc: Andy Gospodarek , netdev@vger.kernel.org Subject: Re: [PATCH] bonding: update docs to correctly reflect arp_ip_target behavior Message-ID: <20081022211938.GA11129@gospo.rdu.redhat.com> References: <20081022200639.GA10873@gospo.rdu.redhat.com> <1473.1224707425@death.nxdomain.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1473.1224707425@death.nxdomain.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 22, 2008 at 01:30:25PM -0700, Jay Vosburgh wrote: > Andy Gospodarek wrote: > > >The latest version of Red Hat Enterprise Linux 5 doesn't need '+' in > >front of each IP address listed as an arp_ip_target, and correctly > >supports a comma separated list of IP addresses using the current > >version of initscripts. This patch drops all references to the need for > >a '+' before each IP address and the description now matches the > >behavior. > > Don't the prior versions of RHEL 5 (initscripts, really) still > need the "+"? If so, I'd prefer to have this say "for initscripts > versions X - Y (RHEL A.B, Fedora Q.Y), do it this way; for versions > since Y (RHEL A.C, Fedora Q.Z), do it this other way." > > I'm not keen on removing information that isn't tied directly to > the bonding driver itself. I just know somebody will run the latest > mainline kernel on their RHEL 5.mumble and then the documentation will > steer them down the wrong road. > > -J Good point, Jay. I didn't include them originally since I didn't think the in-kernel documentation needed to have enough detail to seem like a Red Hat release note. This documentation patch hopes to clarify that the '+' was only needed for Fedora 7 and Red Hat Enterprise Linux 5.0 and 5.1. After that the IP addreses could be added as a comma separated list just like the module option. Signed-off-by: Andy Gospodarek --- bonding.txt | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt index 688dfe1..d733a42 100644 --- a/Documentation/networking/bonding.txt +++ b/Documentation/networking/bonding.txt @@ -922,17 +922,19 @@ USERCTL=no NETMASK, NETWORK and BROADCAST) to match your network configuration. For later versions of initscripts, such as that found with Fedora -7 and Red Hat Enterprise Linux version 5 (or later), it is possible, and, -indeed, preferable, to specify the bonding options in the ifcfg-bond0 +7 (or later) and Red Hat Enterprise Linux version 5 (or later), it is possible, +and, indeed, preferable, to specify the bonding options in the ifcfg-bond0 file, e.g. a line of the format: -BONDING_OPTS="mode=active-backup arp_interval=60 arp_ip_target=+192.168.1.254" +BONDING_OPTS="mode=active-backup arp_interval=60 arp_ip_target=192.168.1.254" will configure the bond with the specified options. The options specified in BONDING_OPTS are identical to the bonding module parameters -except for the arp_ip_target field. Each target should be included as a -separate option and should be preceded by a '+' to indicate it should be -added to the list of queried targets, e.g., +except for the arp_ip_target field when using versions of initscripts older +than and 8.57 (Fedora 8) and 8.45.19 (Red Hat Enterprise Linux 5.2). When +using older versions each target should be included as a separate option and +should be preceded by a '+' to indicate it should be added to the list of +queried targets, e.g., arp_ip_target=+192.168.1.1 arp_ip_target=+192.168.1.2 @@ -940,7 +942,7 @@ added to the list of queried targets, e.g., options via BONDING_OPTS, it is not necessary to edit /etc/modules.conf or /etc/modprobe.conf. - For older versions of initscripts that do not support + For even older versions of initscripts that do not support BONDING_OPTS, it is necessary to edit /etc/modules.conf (or /etc/modprobe.conf, depending upon your distro) to load the bonding module with your desired options when the bond0 interface is brought up. The