Patchwork Fix missing DFS referral increment

login
register
mail settings
Submitter Darren Williams
Date Jan. 21, 2010, 5 a.m.
Message ID <1264050044.3955.92.camel@eos>
Download mbox | patch
Permalink /patch/53745/
State New
Headers show

Comments

Darren Williams - Jan. 21, 2010, 5 a.m.
Hi Guys

Currently if an MSDFS style link is created on a SAMBA server with more
than one target then only the first target is referenced due to a
missing increment.
 
Fix missing increment in DFS referral code, I have tested this code for
both functioning and fail over modes, i.e. first link target accessible
and not accessible.


Signed-off-by: Darren Williams <darren.w at computer.org>
---

Patch

--- linux-2.6.31.6.new/fs/cifs/cifssmb.c.orig	2009-11-26 01:47:05.000000000 +1100
+++ linux-2.6.31.6.new/fs/cifs/cifssmb.c	2009-11-26 01:32:34.000000000 +1100
@@ -3952,7 +3952,7 @@  parse_DFS_referrals(TRANSACTION2_GET_DFS
 	}
 
 	/* collect neccessary data from referrals */
-	for (i = 0; i < *num_of_nodes; i++) {
+	for (i = 0; i < *num_of_nodes; i++, ref++) {
 		char *temp;samba-technical
 		int max_len;
 		struct dfs_info3_param *node = (*target_nodes)+i;