From patchwork Tue Nov 17 07:22:32 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KOSAKI Motohiro X-Patchwork-Id: 53740 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.samba.org (fn.samba.org [216.83.154.106]) by ozlabs.org (Postfix) with ESMTP id 4B88AB7D1C for ; Thu, 27 May 2010 22:36:10 +1000 (EST) Received: from fn.samba.org (localhost [127.0.0.1]) by lists.samba.org (Postfix) with ESMTP id EA615AC41C; Thu, 27 May 2010 06:35:08 -0600 (MDT) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on fn.samba.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.8 tests=BAYES_00,SPF_PASS autolearn=ham version=3.2.5 X-Original-To: linux-cifs-client@lists.samba.org Delivered-To: linux-cifs-client@lists.samba.org Received: from fgwmail8.fujitsu.co.jp (fgwmail8.fujitsu.co.jp [192.51.44.38]) by lists.samba.org (Postfix) with ESMTP id AB5F1AC5A4; Tue, 17 Nov 2009 00:20:42 -0700 (MST) Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) by fgwmail8.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nAH7N8A6010220 (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 17 Nov 2009 16:23:08 +0900 Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id nAH7MYaC000631 (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 17 Nov 2009 16:22:34 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 63E0C45DE50; Tue, 17 Nov 2009 16:22:34 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 402CB45DE4E; Tue, 17 Nov 2009 16:22:34 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 20EAA1DB8037; Tue, 17 Nov 2009 16:22:34 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 98A66E08001; Tue, 17 Nov 2009 16:22:33 +0900 (JST) Received: from m106.css.fujitsu.com (m106 [127.0.0.1]) by m106.s.css.fujitsu.com (Postfix) with ESMTP id 674905B89C1; Tue, 17 Nov 2009 16:22:33 +0900 (JST) Received: from [127.0.0.1] (unknown [10.124.100.179]) by m106.s.css.fujitsu.com (Postfix) with ESMTP id EB3475B89F0; Tue, 17 Nov 2009 16:22:32 +0900 (JST) X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Received: from KOSANOTE2[10.124.100.179] by KOSANOTE2 (FujitsuOutboundMailChecker v1.3.1/9992[10.124.100.179]); Tue, 17 Nov 2009 16:22:34 +0900 (JST) From: KOSAKI Motohiro To: LKML In-Reply-To: <20091117161551.3DD4.A69D9226@jp.fujitsu.com> References: <20091117161551.3DD4.A69D9226@jp.fujitsu.com> Message-Id: <20091117162111.3DE8.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 17 Nov 2009 16:22:32 +0900 (JST) X-Mailman-Approved-At: Thu, 27 May 2010 06:34:19 -0600 Cc: samba-technical@lists.samba.org, Steve French , linux-mm , kosaki.motohiro@jp.fujitsu.com, Andrew Morton , linux-cifs-client@lists.samba.org Subject: [linux-cifs-client] [PATCH 6/7] cifs: Don't use PF_MEMALLOC X-BeenThere: linux-cifs-client@lists.samba.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: The Linux CIFS VFS client List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces@lists.samba.org Errors-To: linux-cifs-client-bounces@lists.samba.org Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few memory, anyone must not prevent it. Otherwise the system cause mysterious hang-up and/or OOM Killer invokation. Cc: Steve French Cc: linux-cifs-client@lists.samba.org Cc: samba-technical@lists.samba.org Signed-off-by: KOSAKI Motohiro --- fs/cifs/connect.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 63ea83f..f9b1553 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -337,7 +337,6 @@ cifs_demultiplex_thread(struct TCP_Server_Info *server) bool isMultiRsp; int reconnect; - current->flags |= PF_MEMALLOC; cFYI(1, ("Demultiplex PID: %d", task_pid_nr(current))); length = atomic_inc_return(&tcpSesAllocCount);