| Message ID | 20100527091128.GT22515@bicker |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Thanks Dan, nice catches. For all three: Acked-by: Andy Grover <andy.grover@oracle.com> -- Andy On Thu, May 27, 2010 at 2:11 AM, Dan Carpenter <error27@gmail.com> wrote: > The "dma_pages" variable is always NULL at this point so the kfree() > isn't needed. > > Signed-off-by: Dan Carpenter <error27@gmail.com> > > diff --git a/net/rds/iw_rdma.c b/net/rds/iw_rdma.c > index 48d5073..742ab6a 100644 > --- a/net/rds/iw_rdma.c > +++ b/net/rds/iw_rdma.c > @@ -334,7 +334,6 @@ static u64 *rds_iw_map_scatterlist(struct rds_iw_device *rds_iwdev, > out_unmap: > ib_dma_unmap_sg(rds_iwdev->dev, sg->list, sg->len, DMA_BIDIRECTIONAL); > sg->dma_len = 0; > - kfree(dma_pages); > return ERR_PTR(ret); > } > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/iw_rdma.c b/net/rds/iw_rdma.c index 48d5073..742ab6a 100644 --- a/net/rds/iw_rdma.c +++ b/net/rds/iw_rdma.c @@ -334,7 +334,6 @@ static u64 *rds_iw_map_scatterlist(struct rds_iw_device *rds_iwdev, out_unmap: ib_dma_unmap_sg(rds_iwdev->dev, sg->list, sg->len, DMA_BIDIRECTIONAL); sg->dma_len = 0; - kfree(dma_pages); return ERR_PTR(ret); }
The "dma_pages" variable is always NULL at this point so the kfree() isn't needed. Signed-off-by: Dan Carpenter <error27@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html