From patchwork Thu May 27 08:28:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext3: fix non-update ctime when changing the file's permission by setfacl Date: Wed, 26 May 2010 22:28:40 -0000 From: Miao Xie X-Patchwork-Id: 53703 Message-Id: <4BFE2D38.2010501@cn.fujitsu.com> To: Andrew Morton , adilger@sun.com Cc: Linux-Ext4 , Linux-Kernel ext3 didn't update the ctime of the file when its permission was changed. Steps to reproduce: # touch aaa # stat -c %Z aaa 1275289822 # setfacl -m 'u::x,g::x,o::x' aaa # stat -c %Z aaa 1275289822 <- unchanged But, according to the spec of the ctime, ext3 must update it. Signed-off-by: Miao Xie --- fs/ext3/acl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c index 01552ab..8a11fe2 100644 --- a/fs/ext3/acl.c +++ b/fs/ext3/acl.c @@ -205,6 +205,7 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type, return error; else { inode->i_mode = mode; + inode->i_ctime = CURRENT_TIME_SEC; ext3_mark_inode_dirty(handle, inode); if (error == 0) acl = NULL;