Patchwork pci.h: remove unused constants.

login
register
mail settings
Submitter Isaku Yamahata
Date May 27, 2010, 5:40 a.m.
Message ID <20100527054002.GE31807@valinux.co.jp>
Download mbox | patch
Permalink /patch/53692/
State New
Headers show

Comments

Isaku Yamahata - May 27, 2010, 5:40 a.m.
So remove unused constants,
PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI,
PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI.
They were used once, but they aren't used anymore.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/pci.h |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
Michael S. Tsirkin - May 27, 2010, 2:14 p.m.
On Thu, May 27, 2010 at 02:40:02PM +0900, Isaku Yamahata wrote:
> So remove unused constants,
> PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI,
> PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI.
> They were used once, but they aren't used anymore.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Applied, thanks!
Also, please cc me on patches.

> ---
>  hw/pci.h |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index f6e6c5f..6eee93a 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -97,17 +97,6 @@ typedef struct PCIIORegion {
>  /* PCI HEADER_TYPE */
>  #define  PCI_HEADER_TYPE_MULTI_FUNCTION 0x80
>  
> -#define PCI_STATUS_RESERVED_MASK_LO (PCI_STATUS_RESERVED1 | \
> -                PCI_STATUS_INT_STATUS | PCI_STATUS_CAPABILITIES | \
> -                PCI_STATUS_66MHZ | PCI_STATUS_RESERVED2 | PCI_STATUS_FAST_BACK)
> -
> -#define PCI_STATUS_RESERVED_MASK_HI (PCI_STATUS_DEVSEL >> 8)
> -
> -/* Bits in the PCI Command Register (PCI 2.3 spec) */
> -#define PCI_COMMAND_RESERVED	0xf800
> -
> -#define PCI_COMMAND_RESERVED_MASK_HI (PCI_COMMAND_RESERVED >> 8)
> -
>  /* Size of the standard PCI config header */
>  #define PCI_CONFIG_HEADER_SIZE 0x40
>  /* Size of the standard PCI config space */
> -- 
> 1.6.6.1
>

Patch

diff --git a/hw/pci.h b/hw/pci.h
index f6e6c5f..6eee93a 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -97,17 +97,6 @@  typedef struct PCIIORegion {
 /* PCI HEADER_TYPE */
 #define  PCI_HEADER_TYPE_MULTI_FUNCTION 0x80
 
-#define PCI_STATUS_RESERVED_MASK_LO (PCI_STATUS_RESERVED1 | \
-                PCI_STATUS_INT_STATUS | PCI_STATUS_CAPABILITIES | \
-                PCI_STATUS_66MHZ | PCI_STATUS_RESERVED2 | PCI_STATUS_FAST_BACK)
-
-#define PCI_STATUS_RESERVED_MASK_HI (PCI_STATUS_DEVSEL >> 8)
-
-/* Bits in the PCI Command Register (PCI 2.3 spec) */
-#define PCI_COMMAND_RESERVED	0xf800
-
-#define PCI_COMMAND_RESERVED_MASK_HI (PCI_COMMAND_RESERVED >> 8)
-
 /* Size of the standard PCI config header */
 #define PCI_CONFIG_HEADER_SIZE 0x40
 /* Size of the standard PCI config space */