Patchwork [Lucid] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb

login
register
mail settings
Submitter Mathieu Poirier
Date May 26, 2010, 10:10 p.m.
Message ID <1274911859.8279.254.camel@black>
Download mbox | patch
Permalink /patch/53665/
State Accepted
Delegated to: Stefan Bader
Headers show

Comments

Mathieu Poirier - May 26, 2010, 10:10 p.m.
>From d9811804ff0a7b6c3aa687c5ec9d0cd2ad7a15a3 Mon Sep 17 00:00:00 2001
From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
Date: Wed, 26 May 2010 15:14:08 -0600
Subject: [PATCH] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb

Adding driver for MosChip MCS7830 usb ethernet device. It was also requested
that module found in the linux-image .deb file also be ported to the nic-usb
.udeb file, which is also done here.

BugLink: https://bugs.launchpad.net/bugs/584920

Signed-off-by: Mathieu Poirier <mpoirier@canonical.com>
---
 debian.ti-omap/d-i/modules/nic-usb-modules |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Chase Douglas - May 27, 2010, 1:57 a.m.
On Wed, 2010-05-26 at 16:10 -0600, Mathieu Poirier wrote:
> >From d9811804ff0a7b6c3aa687c5ec9d0cd2ad7a15a3 Mon Sep 17 00:00:00 2001
> From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
> Date: Wed, 26 May 2010 15:14:08 -0600
> Subject: [PATCH] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb
> 
> Adding driver for MosChip MCS7830 usb ethernet device. It was also requested
> that module found in the linux-image .deb file also be ported to the nic-usb
> .udeb file, which is also done here.
> 
> BugLink: https://bugs.launchpad.net/bugs/584920
> 
> Signed-off-by: Mathieu Poirier <mpoirier@canonical.com>
> ---
>  debian.ti-omap/d-i/modules/nic-usb-modules |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/debian.ti-omap/d-i/modules/nic-usb-modules b/debian.ti-omap/d-i/modules/nic-usb-modules
> index 33b1c11..0934dea 100644
> --- a/debian.ti-omap/d-i/modules/nic-usb-modules
> +++ b/debian.ti-omap/d-i/modules/nic-usb-modules
> @@ -10,4 +10,17 @@ rt2500usb ?
>  rt73usb ?
>  rt2570 ?
>  cdc_ether ?
> +cdc_eem ?
> +cdc-phonet ?
> +cdc_subset ?
> +dm9601 ?
> +gl620a ?
> +hso ?
> +int51x1 ?
> +mcs7830 ?
> +net1080 ?
> +plusb ?
> +rndis_host ?
> +smsc95xx ?
> +zaurus ?
>  asix ?

Some of these modules are very esoteric. I doubt anyone is going to try
to install Lucid on a Zaurus (or tethered through a Zaurus, if that's
what the module does) *. Is there pressure on udeb sizes to make us be
concerned about throwing in modules that may never be used, especially
at install time?

For that matter, what networking support is used at install time? I
assume the only purpose is for alternative installs where you do a
network installation. Are people doing these types of installations with
usb networking?

I assume we also won't be respinning an installation image for lucid, so
I'm not sure how useful these changes are for us. Is the mobile team
spinning new installation images?

-- Chase

* I'd give a pile of change to see someone net install lucid through a
tethered Zaurus. Then I'd laugh at the data plan overages incurred :).
Chase Douglas - May 27, 2010, 2:10 a.m.
On Wed, 2010-05-26 at 21:57 -0400, Chase Douglas wrote:
> For that matter, what networking support is used at install time? I
> assume the only purpose is for alternative installs where you do a
> network installation. Are people doing these types of installations with
> usb networking?
> 
> I assume we also won't be respinning an installation image for lucid, so
> I'm not sure how useful these changes are for us. Is the mobile team
> spinning new installation images?

For these latter two paragraphs, I should have referred to the
BugLink :). It seems we do have people using usb networking for net
installations, and the bug was filed by someone on our mobile team, so
they must be respinning installation images.

Still, I think we may want to consider paring the additions down to
modern modules to conserve space.

-- Chase
Amit Kucheria - May 27, 2010, 7:19 a.m.
On 10 May 26, Chase Douglas wrote:
> On Wed, 2010-05-26 at 21:57 -0400, Chase Douglas wrote:
> > For that matter, what networking support is used at install time? I
> > assume the only purpose is for alternative installs where you do a
> > network installation. Are people doing these types of installations with
> > usb networking?
> > 
> > I assume we also won't be respinning an installation image for lucid, so
> > I'm not sure how useful these changes are for us. Is the mobile team
> > spinning new installation images?
> 
> For these latter two paragraphs, I should have referred to the
> BugLink :). It seems we do have people using usb networking for net
> installations, and the bug was filed by someone on our mobile team, so
> they must be respinning installation images.

LTS releases are respun (every 6 months?). So we will see a 10.04.1, 10.04.2,
etc.

> Still, I think we may want to consider paring the additions down to
> modern modules to conserve space.

I believe that the ? indicates that only those modules that are built are
included in the .udeb.

Cheers,
Amit
Oliver Grawert - May 27, 2010, 7:30 a.m.
hi,
Am Mittwoch, den 26.05.2010, 21:57 -0400 schrieb Chase Douglas:

> Some of these modules are very esoteric. I doubt anyone is going to try
> to install Lucid on a Zaurus (or tethered through a Zaurus, if that's
> what the module does) *. Is there pressure on udeb sizes to make us be
> concerned about throwing in modules that may never be used, especially
> at install time?
note that this is for ARM, there are plenty of ARM users that own a
fully working zaurus and also use a beagleboard, if you lack a NIC but
have an OTG cable to hook up to your zaurus thats a good option to get
network connection ...

yes, i know us ARM people are a bit crazy but we shouldnt limit the HW
support based on mental state of the users *g*
> 
> For that matter, what networking support is used at install time? I
> assume the only purpose is for alternative installs where you do a
> network installation. Are people doing these types of installations with
> usb networking?
yes, 100% of the beagleboard users (and many many other ARM board users
of boards that dont come with an on board NIC and for which the only
external socket to attach other devices is USB).
note that the netinstall [1] image on the beagle [2] is the only way of
not having to use an additional target device (you can install directly
to the SD card you booted from instead of having to use a USB disk/key
additionally) so it is very popular.
> 
> I assume we also won't be respinning an installation image for lucid, so
> I'm not sure how useful these changes are for us. Is the mobile team
> spinning new installation images?
we are building a 10.07 omap release based on 10.04.1 and i would also
suspect that the 10.10 config is roughly based on the 10.04 one.

ciao
	oli

[1] https://wiki.ubuntu.com/ARM/BeagleNetInstall
[2] https://wiki.ubuntu.com/ARM/Beagle
Amit Kucheria - May 27, 2010, 7:47 a.m.
On 10 May 26, Mathieu Poirier wrote:
> >From d9811804ff0a7b6c3aa687c5ec9d0cd2ad7a15a3 Mon Sep 17 00:00:00 2001
> From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
> Date: Wed, 26 May 2010 15:14:08 -0600
> Subject: [PATCH] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb
> 
> Adding driver for MosChip MCS7830 usb ethernet device. It was also requested
> that module found in the linux-image .deb file also be ported to the nic-usb
> .udeb file, which is also done here.
> 
> BugLink: https://bugs.launchpad.net/bugs/584920
> 
> Signed-off-by: Mathieu Poirier <mpoirier@canonical.com>
> ---
>  debian.ti-omap/d-i/modules/nic-usb-modules |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/debian.ti-omap/d-i/modules/nic-usb-modules b/debian.ti-omap/d-i/modules/nic-usb-modules
> index 33b1c11..0934dea 100644
> --- a/debian.ti-omap/d-i/modules/nic-usb-modules
> +++ b/debian.ti-omap/d-i/modules/nic-usb-modules
> @@ -10,4 +10,17 @@ rt2500usb ?
>  rt73usb ?
>  rt2570 ?
>  cdc_ether ?
> +cdc_eem ?
> +cdc-phonet ?
> +cdc_subset ?
> +dm9601 ?
> +gl620a ?
> +hso ?
> +int51x1 ?
> +mcs7830 ?
> +net1080 ?
> +plusb ?
> +rndis_host ?
> +smsc95xx ?
> +zaurus ?
>  asix ?
> -- 
> 1.7.0.4
> 

Acked-by: Amit Kucheria <amit.kucheria@canonical.com>

Mathieu, could you make sure this is sane for Maverick as well?
Chase Douglas - May 27, 2010, 12:07 p.m.
On Wed, 2010-05-26 at 16:10 -0600, Mathieu Poirier wrote:
> >From d9811804ff0a7b6c3aa687c5ec9d0cd2ad7a15a3 Mon Sep 17 00:00:00 2001
> From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
> Date: Wed, 26 May 2010 15:14:08 -0600
> Subject: [PATCH] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb
> 
> Adding driver for MosChip MCS7830 usb ethernet device. It was also requested
> that module found in the linux-image .deb file also be ported to the nic-usb
> .udeb file, which is also done here.
> 
> BugLink: https://bugs.launchpad.net/bugs/584920
> 
> Signed-off-by: Mathieu Poirier <mpoirier@canonical.com>
> ---
>  debian.ti-omap/d-i/modules/nic-usb-modules |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/debian.ti-omap/d-i/modules/nic-usb-modules b/debian.ti-omap/d-i/modules/nic-usb-modules
> index 33b1c11..0934dea 100644
> --- a/debian.ti-omap/d-i/modules/nic-usb-modules
> +++ b/debian.ti-omap/d-i/modules/nic-usb-modules
> @@ -10,4 +10,17 @@ rt2500usb ?
>  rt73usb ?
>  rt2570 ?
>  cdc_ether ?
> +cdc_eem ?
> +cdc-phonet ?
> +cdc_subset ?
> +dm9601 ?
> +gl620a ?
> +hso ?
> +int51x1 ?
> +mcs7830 ?
> +net1080 ?
> +plusb ?
> +rndis_host ?
> +smsc95xx ?
> +zaurus ?
>  asix ?

I've been convinced by the ARM guys that this is all sane :).

Acked-by: Chase Douglas <chase.douglas@canonical.com>
Stefan Bader - May 27, 2010, 1:19 p.m.
Adding modules to the installer list sounds quite acceptable to me. The only
chance of regression would be module explodes when loaded, but then those would
have no network for installation before...

One favour for future requests, could you make it [Lucid ti-omap]? Makes it
simpler for the old chap to put it into the right bucket. ;-P

-Stefan

On 05/27/2010 12:10 AM, Mathieu Poirier wrote:
>>From d9811804ff0a7b6c3aa687c5ec9d0cd2ad7a15a3 Mon Sep 17 00:00:00 2001
> From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
> Date: Wed, 26 May 2010 15:14:08 -0600
> Subject: [PATCH] UBUNTU: ARM: Adding MosChip MCS7830 to nic-usb
> 
> Adding driver for MosChip MCS7830 usb ethernet device. It was also requested
> that module found in the linux-image .deb file also be ported to the nic-usb
> .udeb file, which is also done here.
> 
> BugLink: https://bugs.launchpad.net/bugs/584920
> 
> Signed-off-by: Mathieu Poirier <mpoirier@canonical.com>
> ---
>  debian.ti-omap/d-i/modules/nic-usb-modules |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/debian.ti-omap/d-i/modules/nic-usb-modules b/debian.ti-omap/d-i/modules/nic-usb-modules
> index 33b1c11..0934dea 100644
> --- a/debian.ti-omap/d-i/modules/nic-usb-modules
> +++ b/debian.ti-omap/d-i/modules/nic-usb-modules
> @@ -10,4 +10,17 @@ rt2500usb ?
>  rt73usb ?
>  rt2570 ?
>  cdc_ether ?
> +cdc_eem ?
> +cdc-phonet ?
> +cdc_subset ?
> +dm9601 ?
> +gl620a ?
> +hso ?
> +int51x1 ?
> +mcs7830 ?
> +net1080 ?
> +plusb ?
> +rndis_host ?
> +smsc95xx ?
> +zaurus ?
>  asix ?
Stefan Bader - June 7, 2010, 12:26 p.m.
Applied to Lucid ti-omap

Patch

diff --git a/debian.ti-omap/d-i/modules/nic-usb-modules b/debian.ti-omap/d-i/modules/nic-usb-modules
index 33b1c11..0934dea 100644
--- a/debian.ti-omap/d-i/modules/nic-usb-modules
+++ b/debian.ti-omap/d-i/modules/nic-usb-modules
@@ -10,4 +10,17 @@  rt2500usb ?
 rt73usb ?
 rt2570 ?
 cdc_ether ?
+cdc_eem ?
+cdc-phonet ?
+cdc_subset ?
+dm9601 ?
+gl620a ?
+hso ?
+int51x1 ?
+mcs7830 ?
+net1080 ?
+plusb ?
+rndis_host ?
+smsc95xx ?
+zaurus ?
 asix ?