Patchwork Re: hw/serial.c: Xmit fifo never used

login
register
mail settings
Submitter Frank Mehnert
Date May 26, 2010, 8:06 p.m.
Message ID <201005262206.11919.frank.mehnert@sun.com>
Download mbox | patch
Permalink /patch/53661/
State New
Headers show

Comments

Frank Mehnert - May 26, 2010, 8:06 p.m.
On Wednesday 26 May 2010, Stefano Stabellini wrote:
> I think the patch is correct.

serial: fixed bug which prevented the use of the xmit fifo

Signed-off-by: Frank Mehnert <frank.mehnert@sun.com>
---
 hw/serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

             return;
--
1.5.6.5



Hope this is now the correct format.

Kind regards,

Frank
Jan Kiszka - May 27, 2010, 8:21 a.m.
Frank Mehnert wrote:
> On Wednesday 26 May 2010, Stefano Stabellini wrote:
>> I think the patch is correct.
> 
> serial: fixed bug which prevented the use of the xmit fifo
> 
> Signed-off-by: Frank Mehnert <frank.mehnert@sun.com>
> ---
>  hw/serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/serial.c b/hw/serial.c
> index 9102edb..0b1550b 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -327,7 +327,7 @@ static void serial_xmit(void *opaque)
>          /* in loopback mode, say that we just received a char */
>          serial_receive1(s, &s->tsr, 1);
>      } else if (qemu_chr_write(s->chr, &s->tsr, 1) != 1) {
> -        if ((s->tsr_retry > 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
> +        if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
>              s->tsr_retry++;
>              qemu_mod_timer(s->transmit_timer,  new_xmit_ts + 
> s->char_transmit_time);
>              return;
> --
> 1.5.6.5
> 
> 
> 
> Hope this is now the correct format.

Really close: Without "[PATCH]" prefix in the subject line there is the
risk that no maintainer will find your patch. Moreover, your mail client
wrapped long lines.

Jan

Patch

diff --git a/hw/serial.c b/hw/serial.c
index 9102edb..0b1550b 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -327,7 +327,7 @@  static void serial_xmit(void *opaque)
         /* in loopback mode, say that we just received a char */
         serial_receive1(s, &s->tsr, 1);
     } else if (qemu_chr_write(s->chr, &s->tsr, 1) != 1) {
-        if ((s->tsr_retry > 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
+        if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
             s->tsr_retry++;
             qemu_mod_timer(s->transmit_timer,  new_xmit_ts + 
s->char_transmit_time);