From patchwork Wed May 26 17:53:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 53655 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0B719B7D12 for ; Thu, 27 May 2010 03:55:22 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1OHKne-00085X-4r; Wed, 26 May 2010 17:53:50 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1OHKnG-0007po-S8 for linux-mtd@lists.infradead.org; Wed, 26 May 2010 17:53:28 +0000 Received: from octopus.hi.pengutronix.de ([2001:6f8:1178:2:215:17ff:fe12:23b0]) by metis.ext.pengutronix.de with esmtp (Exim 4.71) (envelope-from ) id 1OHKnA-00027x-2G for linux-mtd@lists.infradead.org; Wed, 26 May 2010 19:53:20 +0200 Received: from wsa by octopus.hi.pengutronix.de with local (Exim 4.69) (envelope-from ) id 1OHKnA-00060s-18 for linux-mtd@lists.infradead.org; Wed, 26 May 2010 19:53:20 +0200 Date: Wed, 26 May 2010 19:53:20 +0200 From: Wolfram Sang To: linux-mtd@lists.infradead.org Subject: Do we remove from jedec_probe.c? Message-ID: <20100526175320.GD24167@pengutronix.de> MIME-Version: 1.0 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100526_135327_263637_21152EA3 X-CRM114-Status: GOOD ( 20.24 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi, now that Guillaume introduced cfi-support for some SST-flashes, I wonder if those can be removed from jedec_probe.c? Or should they stay for backward-compatibility? Proposed patch would look like this: diff --git a/drivers/mtd/chips/jedec_probe.c b/drivers/mtd/chips/jedec_probe.c index d72a5fb..37fdff3 100644 --- a/drivers/mtd/chips/jedec_probe.c +++ b/drivers/mtd/chips/jedec_probe.c @@ -146,8 +146,6 @@ #define SST29LE512 0x003d #define SST39LF800 0x2781 #define SST39LF160 0x2782 -#define SST39VF1601 0x234b -#define SST39VF3201 0x235b #define SST39WF1601 0x274b #define SST39WF1602 0x274a #define SST39LF512 0x00D4 @@ -1500,19 +1498,6 @@ static const struct amd_flash_info jedec_table[] = { ERASEINFO(0x1000,256) } }, { - .mfr_id = CFI_MFR_SST, /* should be CFI */ - .dev_id = SST39VF1601, - .name = "SST 39VF1601", - .devtypes = CFI_DEVICETYPE_X16, - .uaddr = MTD_UADDR_0xAAAA_0x5555, - .dev_size = SIZE_2MiB, - .cmd_set = P_ID_AMD_STD, - .nr_regions = 2, - .regions = { - ERASEINFO(0x1000,256), - ERASEINFO(0x1000,256) - } - }, { /* CFI is broken: reports AMD_STD, but needs custom uaddr */ .mfr_id = CFI_MFR_SST, .dev_id = SST39WF1601, @@ -1541,21 +1526,6 @@ static const struct amd_flash_info jedec_table[] = { ERASEINFO(0x1000,256) } }, { - .mfr_id = CFI_MFR_SST, /* should be CFI */ - .dev_id = SST39VF3201, - .name = "SST 39VF3201", - .devtypes = CFI_DEVICETYPE_X16, - .uaddr = MTD_UADDR_0xAAAA_0x5555, - .dev_size = SIZE_4MiB, - .cmd_set = P_ID_AMD_STD, - .nr_regions = 4, - .regions = { - ERASEINFO(0x1000,256), - ERASEINFO(0x1000,256), - ERASEINFO(0x1000,256), - ERASEINFO(0x1000,256) - } - }, { .mfr_id = CFI_MFR_SST, .dev_id = SST36VF3203, .name = "SST 36VF3203",