diff mbox

[v11,08/24] qapi-types: Refactor base fields output

Message ID 1445898903-12082-9-git-send-email-eblake@redhat.com
State New
Headers show

Commit Message

Eric Blake Oct. 26, 2015, 10:34 p.m. UTC 
Move code from gen_union() into gen_struct_fields() in order for
a later patch to share code when enumerating inherited fields
for struct types.

No change to generated code.

Signed-off-by: Eric Blake <eblake@redhat.com>

---
v11: rename variable and open-code loop rather than recurse, for
clarity
v10: new patch, split off of 5/17
---
 scripts/qapi-types.py | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
diff mbox

Patch

diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 4fe618e..40e9f79 100644
--- a/scripts/qapi-types.py
+++ b/scripts/qapi-types.py
@@ -51,10 +51,21 @@  def gen_struct_field(name, typ, optional):
     return ret


-def gen_struct_fields(members):
+def gen_struct_fields(local_members, base=None):
     ret = ''

-    for memb in members:
+    if base:
+        ret += mcgen('''
+    /* Members inherited from %(c_name)s: */
+''',
+                     c_name=base.c_name())
+        for memb in base.members:
+            ret += gen_struct_field(memb.name, memb.type, memb.optional)
+        ret += mcgen('''
+    /* Own members: */
+''')
+
+    for memb in local_members:
         ret += gen_struct_field(memb.name, memb.type, memb.optional)
     return ret

@@ -126,14 +137,7 @@  struct %(c_name)s {
 ''',
                 c_name=c_name(name))
     if base:
-        ret += mcgen('''
-    /* Members inherited from %(c_name)s: */
-''',
-                     c_name=c_name(base.name))
-        ret += gen_struct_fields(base.members)
-        ret += mcgen('''
-    /* Own members: */
-''')
+        ret += gen_struct_fields([], base)
     else:
         ret += mcgen('''
     %(c_type)s kind;