From patchwork Wed May 26 14:08:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 53627 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D815B7D1B for ; Thu, 27 May 2010 00:58:13 +1000 (EST) Received: from localhost ([127.0.0.1]:34105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHI3d-0001Ol-60 for incoming@patchwork.ozlabs.org; Wed, 26 May 2010 10:58:09 -0400 Received: from [140.186.70.92] (port=45304 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHHNJ-0003KG-BA for qemu-devel@nongnu.org; Wed, 26 May 2010 10:14:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHHHj-0003rX-F9 for qemu-devel@nongnu.org; Wed, 26 May 2010 10:08:40 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:61762) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHHHj-0003qp-9P for qemu-devel@nongnu.org; Wed, 26 May 2010 10:08:39 -0400 Received: by mail-wy0-f173.google.com with SMTP id 28so1006241wyf.4 for ; Wed, 26 May 2010 07:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :message-id:x-mailer:in-reply-to:references; bh=HsGTZeBbJskeN2kQJOlr2LQiBMlieQXzNnzhpIwm4fI=; b=cEKHA6SX8VB8WiA1DIkPVARx8UjyUPXbYrOODaNba8zlZLhG06ae+oYU3cfaz5PyP4 FQxCEdOPgBiml7VzqFNukHa59MuMMLpPvTBZH8Cgb6YTakCODlCx/zC3fPIjbbB15X9X 8NKCH3scOJWmScuKO7uAOWtItBB73G+yPkZQk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; b=DqQQF/SDdBKzSw0OdDLPOAzJdlH83agf/twD6enCahhP1A9O4bMHZKPOEoSDpjyZtW xTIGL3n7PEZieFt6xz2t8+RwM2L5rcRk3O/KeNM4C4jQHERvx+h8MPqikXLgk0aQGPyo I/nLDQzti19A/ckHhUbrBpbfKBg1WwJVg48zA= Received: by 10.227.127.76 with SMTP id f12mr8446456wbs.206.1274882918977; Wed, 26 May 2010 07:08:38 -0700 (PDT) Received: from localhost.localdomain (nat-pool-brq-t.redhat.com [209.132.186.34]) by mx.google.com with ESMTPS id z33sm890140wbd.1.2010.05.26.07.08.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 May 2010 07:08:38 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 26 May 2010 16:08:17 +0200 Message-Id: <1274882909-9800-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: <1274882909-9800-1-git-send-email-pbonzini@redhat.com> References: <1274882909-9800-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 02/14] avoid using expr in configure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Just a personal preference against duplicating hieroglyphics. Signed-off-by: Paolo Bonzini --- configure | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8dd2ef..5a7cb6e 100755 --- a/configure +++ b/configure @@ -928,6 +928,13 @@ if test -z "$target_list" ; then echo "No targets enabled" exit 1 fi +# see if system emulation was really requested +case " $target_list " in + *"-softmmu "*) softmmu=yes + ;; + *) softmmu=no + ;; +esac feature_not_found() { feature=$1 @@ -2282,7 +2289,7 @@ bsd) esac tools= -if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then +if test "$softmmu" = yes ; then tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools" if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) $tools" @@ -2298,7 +2305,7 @@ echo "TOOLS=$tools" >> $config_host_mak roms= if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \ "$targetos" != "Darwin" -a "$targetos" != "SunOS" -a \ - `expr "$target_list" : ".*softmmu.*"` != 0 ; then + "$softmmu" = yes ; then roms="optionrom" fi echo "ROMS=$roms" >> $config_host_mak